misc: Move IndexJoinNode to SPI

[feilong-liu]

Description

As title, move IndexJoinNode to SPI so that it's available in ApplyConnectorOptimizer

Motivation and Context

As title

Impact

In description.

Test Plan

Easy change, existing unit tests

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's Guide

Refactored IndexJoinNode into the SPI module and updated all dependent code, serialization, and optimizers to recognize the relocated class, while replacing Guava ImmutableList usage with java.util unmodifiableList.

Class diagram for relocated IndexJoinNode in SPI

classDiagram
    class PlanNode {
        <<abstract>>
        +List<VariableReferenceExpression> getOutputVariables()
        +List<PlanNode> getSources()
        +<R, C> R accept(PlanVisitor<R, C> visitor, C context)
    }
    class JoinType
    class RowExpression
    class VariableReferenceExpression
    class IndexJoinNode {
        +JoinType type
        +PlanNode probeSource
        +PlanNode indexSource
        +List<Pair<VariableReferenceExpression, VariableReferenceExpression>> criteria
        +Optional<RowExpression> filter
        +Optional<VariableReferenceExpression> probeHashVariable
        +Optional<VariableReferenceExpression> indexHashVariable
        +List<VariableReferenceExpression> getLookupVariables()
        +List<PlanNode> getSources()
        +List<VariableReferenceExpression> getOutputVariables()
        +<R, C> R accept(PlanVisitor<R, C> visitor, C context)
    }
    PlanNode <|-- IndexJoinNode
    IndexJoinNode o-- JoinType
    IndexJoinNode o-- PlanNode : probeSource
    IndexJoinNode o-- PlanNode : indexSource
    IndexJoinNode o-- RowExpression : filter
    IndexJoinNode o-- VariableReferenceExpression : probeHashVariable
    IndexJoinNode o-- VariableReferenceExpression : indexHashVariable
    IndexJoinNode o-- VariableReferenceExpression : criteria

Loading

Class diagram for PlanVisitor with new visitIndexJoin method

classDiagram
    class PlanVisitor {
        +R visitJoin(JoinNode node, C context)
        +R visitIndexJoin(IndexJoinNode node, C context)
        +R visitSemiJoin(SemiJoinNode node, C context)
        +R visitPlan(PlanNode node, C context)
    }
    class IndexJoinNode
    PlanVisitor ..> IndexJoinNode : visitIndexJoin

Loading

File-Level Changes

Change	Details	Files
Relocate IndexJoinNode from planner package to SPI	Changed package declaration and imports in IndexJoinNode Updated class to extend PlanNode instead of InternalPlanNode Moved Java source from presto-main-base to presto-spi Adjusted YML JavaClasses entries to reference SPI path	presto-spi/src/main/java/com/facebook/presto/spi/plan/IndexJoinNode.java presto-main-base/src/main/java/com/facebook/presto/sql/planner/plan/IndexJoinNode.java presto-native-execution/presto_cpp/presto_protocol/core/presto_protocol_core.yml presto-native-execution/presto_cpp/presto_protocol/presto_protocol.yml
Replace Guava ImmutableList with unmodifiableList	Replaced ImmutableList.copyOf with Collections.unmodifiableList Rewrote getSources and getOutputVariables to build via ArrayList Swapped com.google.common import to java.util	presto-spi/src/main/java/com/facebook/presto/spi/plan/IndexJoinNode.java
Update C++ protocol serialization for IndexJoinNode	Changed @type and type keys to ".IndexJoinNode" Updated to_json/from_json in core.cpp and header Adjusted YAML entries for serialization keys	presto-native-execution/presto_cpp/presto_protocol/core/presto_protocol_core.cpp presto-native-execution/presto_cpp/presto_protocol/core/presto_protocol_core.h presto-native-execution/presto_cpp/presto_protocol/core/presto_protocol_core.yml presto-native-execution/presto_cpp/presto_protocol/presto_protocol.yml
Support IndexJoinNode in visitor and optimizer	Added visitIndexJoin to PlanVisitor Included IndexJoinNode in ApplyConnectorOptimization node list Updated test import for TestNativeIndexJoinLogicalPlanner	presto-spi/src/main/java/com/facebook/presto/spi/plan/PlanVisitor.java presto-main-base/src/main/java/com/facebook/presto/sql/planner/optimizations/ApplyConnectorOptimization.java presto-tests/src/test/java/com/facebook/presto/tests/TestNativeIndexJoinLogicalPlanner.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rschlussel]

remove index join from internalPlanVisitor

[rschlussel]

we should have some sanity check for this. It's very easy to miss.

[feilong-liu]

Removed from internalPlanVisitor

[hantangwangd]

Thanks @feilong-liu, lgtm!

[feilong-liu]

Thanks @hantangwangd and @rschlussel for reviewing this PR. The prestocpp-linux-build / prestocpp-linux-build-engine (pull_request) CI job has been consistently failing due to disk full error, so I created another PR #26270 following a previous PR #24331 to save some disk space, can I get a review for that PR too? Thanks!

[feilong-liu]

Replaced by #26289