Skip to content

Conversation

@czentgr
Copy link
Contributor

@czentgr czentgr commented Jan 7, 2025

The debug build for PrestoC++ fails as we are running out of disk. The disk space is limited and this is one way of reducing the size. Tests are not being built here and can be removed.

In addition, a newer, smaller dependency image is being used to reduce
the disk space consumption even more.

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 7, 2025
@prestodb-ci prestodb-ci requested review from a team, auden-woolfson and imsayari404 and removed request for a team January 7, 2025 23:15
@czentgr czentgr force-pushed the cz_delete_files branch 2 times, most recently from b6e2e87 to 809e066 Compare January 8, 2025 00:05
@czentgr czentgr marked this pull request as ready for review January 8, 2025 03:55
@czentgr czentgr requested a review from a team as a code owner January 8, 2025 03:55
@czentgr
Copy link
Contributor Author

czentgr commented Jan 8, 2025

@majetideepak A quick workaround to get some more free disk space to unblock until we have the newer dependency image. The job doesn't have a warning that we are running out of space anymore.

majetideepak
majetideepak previously approved these changes Jan 8, 2025
auden-woolfson
auden-woolfson previously approved these changes Jan 8, 2025
@czentgr czentgr dismissed stale reviews from majetideepak and auden-woolfson via 353d497 January 8, 2025 18:50
@czentgr czentgr force-pushed the cz_delete_files branch 4 times, most recently from 19335f3 to 67d9fc8 Compare January 8, 2025 20:48
The debug build for PrestoC++ fails as we are running out of disk.
The disk space is limited and this is one way of reducing the size.
Tests are not being built here and can be removed.

In addition, a newer, smaller dependency image is being used to reduce
the disk space consumption even more.
@czentgr
Copy link
Contributor Author

czentgr commented Jan 8, 2025

@majetideepak Using the cleaned up dependency image worked.

@tdcmeehan tdcmeehan merged commit bef2e4d into prestodb:master Jan 9, 2025
53 checks passed
feilong-liu added a commit that referenced this pull request Oct 10, 2025
…inux-build-engine job (#26270)

## Description
Reduce disk consumption for prestocpp-linux-build-engine.
I have a PR #26218 which
consistently fail due to disk full. Similar to
#24331, this PR further remove
files which are not used in the CI build.

## Motivation and Context
As in description.

## Impact
Fix failed CI test

## Test Plan
The CI test completes successfully
https://github.com/prestodb/presto/actions/runs/18389979579/job/52397841783?pr=26270

## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.

## Release Notes
Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.


If release note is NOT required, use:

```
== NO RELEASE NOTE ==
```
imsayari404 pushed a commit to imsayari404/presto that referenced this pull request Oct 13, 2025
…inux-build-engine job (prestodb#26270)

## Description
Reduce disk consumption for prestocpp-linux-build-engine.
I have a PR prestodb#26218 which
consistently fail due to disk full. Similar to
prestodb#24331, this PR further remove
files which are not used in the CI build.

## Motivation and Context
As in description.

## Impact
Fix failed CI test

## Test Plan
The CI test completes successfully
https://github.com/prestodb/presto/actions/runs/18389979579/job/52397841783?pr=26270

## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.

## Release Notes
Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.


If release note is NOT required, use:

```
== NO RELEASE NOTE ==
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants