-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[native] Delete files not needed for the debug build #24331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6e2e87 to
809e066
Compare
Contributor
Author
|
@majetideepak A quick workaround to get some more free disk space to unblock until we have the newer dependency image. The job doesn't have a warning that we are running out of space anymore. |
majetideepak
previously approved these changes
Jan 8, 2025
auden-woolfson
previously approved these changes
Jan 8, 2025
809e066 to
fe2df96
Compare
353d497
19335f3 to
67d9fc8
Compare
The debug build for PrestoC++ fails as we are running out of disk. The disk space is limited and this is one way of reducing the size. Tests are not being built here and can be removed. In addition, a newer, smaller dependency image is being used to reduce the disk space consumption even more.
67d9fc8 to
a4f0392
Compare
Contributor
Author
|
@majetideepak Using the cleaned up dependency image worked. |
majetideepak
approved these changes
Jan 9, 2025
tdcmeehan
approved these changes
Jan 9, 2025
This was referenced Oct 9, 2025
Merged
feilong-liu
added a commit
that referenced
this pull request
Oct 10, 2025
…inux-build-engine job (#26270) ## Description Reduce disk consumption for prestocpp-linux-build-engine. I have a PR #26218 which consistently fail due to disk full. Similar to #24331, this PR further remove files which are not used in the CI build. ## Motivation and Context As in description. ## Impact Fix failed CI test ## Test Plan The CI test completes successfully https://github.com/prestodb/presto/actions/runs/18389979579/job/52397841783?pr=26270 ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. If release note is NOT required, use: ``` == NO RELEASE NOTE == ```
imsayari404
pushed a commit
to imsayari404/presto
that referenced
this pull request
Oct 13, 2025
…inux-build-engine job (prestodb#26270) ## Description Reduce disk consumption for prestocpp-linux-build-engine. I have a PR prestodb#26218 which consistently fail due to disk full. Similar to prestodb#24331, this PR further remove files which are not used in the CI build. ## Motivation and Context As in description. ## Impact Fix failed CI test ## Test Plan The CI test completes successfully https://github.com/prestodb/presto/actions/runs/18389979579/job/52397841783?pr=26270 ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. If release note is NOT required, use: ``` == NO RELEASE NOTE == ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug build for PrestoC++ fails as we are running out of disk. The disk space is limited and this is one way of reducing the size. Tests are not being built here and can be removed.
In addition, a newer, smaller dependency image is being used to reduce
the disk space consumption even more.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.