[native] Update to use C++20#25636
Merged
aditi-pandit merged 1 commit intoprestodb:masterfrom Jul 31, 2025
Merged
Conversation
czentgr
force-pushed
the
cz_cpp20_support
branch
from
7c1c7a4 to
f2fbcc7
Compare
prestodb-ci
requested review from
a team,
ShahimSharafudeen and
anandamideShakyan
and removed request for
a team
pdabre12
previously approved these changes
Jul 29, 2025
steveburnett
previously approved these changes
Jul 30, 2025
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
"View file" to review the README.md as it will be displayed. Thanks!
PingLiuPing
reviewed
Jul 30, 2025
| # Set all Velox options below | ||
| # Make sure that if we include folly headers or other dependency headers | ||
| # that include folly headers we turn off the coroutines and turn on int128. | ||
| # Set all Velox options below Make sure that if we include folly headers or |
Contributor
There was a problem hiding this comment.
Do you want to add a comma here below Make. Or change Make to make?
Contributor
Author
There was a problem hiding this comment.
Yeah, that was the formatting change and it rearranged the text.
Contributor
Author
There was a problem hiding this comment.
I made a change - causes re-review.
PingLiuPing
reviewed
Jul 30, 2025
| EXPECT_EQ(metadataList.size(), expectedSize); | ||
| std::string expectedStr = slurp(test::utils::getDataPath(expectedFile)); | ||
| auto expected = json::parse(expectedStr); | ||
| auto comparator = [](const json& a, const json& b) { |
Contributor
There was a problem hiding this comment.
Is this relate to C++ 20 compiler upgrade?
Contributor
Author
There was a problem hiding this comment.
Yes. The comparator behaved differently.
6 tasks
PingLiuPing
previously approved these changes
Jul 31, 2025
This updates the C++ standard to C++20 to match the Velox C++ standard.
czentgr
dismissed stale reviews from PingLiuPing, steveburnett, aditi-pandit, and pdabre12
via
1f5b617
czentgr
force-pushed
the
cz_cpp20_support
branch
from
f2fbcc7 to
1f5b617
Compare
czentgr
requested review from
PingLiuPing,
aditi-pandit,
pdabre12 and
steveburnett
steveburnett
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the C++ standard to C++20 to match
the Velox C++ standard.
Resolves #25634
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.