[native] Add TextReader and TextWriter#25626
[native] Add TextReader and TextWriter#25626YiChengLee03 wants to merge 1 commit intoprestodb:masterfrom
Conversation
|
@YiChengLee03 : Thanks for these code changes. Please can you add some e2e tests for this PR. If Text is a valid Hive storage format, then it would be good to add this as a storage format in https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/PrestoNativeQueryRunnerUtils.java#L92, so that we can easily flip Native tests to use text format (just like we can switch between DWRF and Parquet). |
Sure! Thanks for catching that! |
YiChengLee03
force-pushed
the
master
branch
5 times, most recently
from
b7963b7 to
b168d30
Compare
|
@YiChengLee03 @zacw7 can we get this PR approved and merge?Thanks. |
|
@YiChengLee03 @zacw7 Are you still working on this PR? If not, I can help with it. |
Please feel free to take it over. I can also resubmit this change. |
## Description <!---Describe your changes in detail--> Add TextReader registration. It's a continuation of #25626. ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == RELEASE NOTES == Prestissimo (Native Execution) Changes * Add TextReader support for tables in TEXTFILE format. ```
5 participants
Description
Register Reader and Writer
Motivation and Context
Add support for Textfile reader and writer
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.