Skip to content

[pos][native] Restore Pos native session properties#25539

Open
shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
shrinidhijoshi:SV-spark2.4-v2
Open

[pos][native] Restore Pos native session properties#25539
shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
shrinidhijoshi:SV-spark2.4-v2

Conversation

@shrinidhijoshi
Copy link
Collaborator

@shrinidhijoshi shrinidhijoshi commented Jul 15, 2025

Restore presto-on-spark native session properties

Description

This diff re-introduces 2 session properties deleted as a part of #22183.

  • native_execution_executable_path
  • native_execution_program_arguments

But these are introduced in the PrestoOnSparkSessionProperties so that they are only available to Presto-on-Spark

Also, we move out the existing property native_execution_process_reuse_enabled
to PrestoOnSparkSessionProperties well, as this too is a Presto-on-Spark specific property

Motivation and Context

We need these session properties for PoS Native

Impact

Test Plan

CI/Unit tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add `native_execution_executable_path`, `native_execution_program_arguments` as Presto-on-Spark specific session properties
* Update `native_execution_process_reuse_enabled` from being a Presto session property to being a Presto-on-Spark specific session property

@shrinidhijoshi shrinidhijoshi requested a review from a team as a code owner July 15, 2025 06:23
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jul 15, 2025
@shrinidhijoshi shrinidhijoshi changed the title [pos][native] Add new PrestoSparkSessionProperties for native execution [pos][native] Restore Pos native session properties Jul 15, 2025
This diff re-introduces 2 session properties
 - native_execution_executable_path,
 - native_execution_program_arguments
deleted as a part of prestodb#22183.

But these are introduced in the PrestoOnSparkSessionProperties so that
they are only available to Presto-on-Spark

Also, we move out the existing property `native_execution_process_reuse_enabled`
to the same location as well, as this too is a Presto-on-Spark specific property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants