[pos][native] Restore Pos native session properties#25539
Open
shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
Open
[pos][native] Restore Pos native session properties#25539shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
shrinidhijoshi wants to merge 1 commit intoprestodb:masterfrom
Conversation
8ba759a to
0baa61d
Compare
This diff re-introduces 2 session properties - native_execution_executable_path, - native_execution_program_arguments deleted as a part of prestodb#22183. But these are introduced in the PrestoOnSparkSessionProperties so that they are only available to Presto-on-Spark Also, we move out the existing property `native_execution_process_reuse_enabled` to the same location as well, as this too is a Presto-on-Spark specific property
0baa61d to
970e66d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore presto-on-spark native session properties
Description
This diff re-introduces 2 session properties deleted as a part of #22183.
But these are introduced in the PrestoOnSparkSessionProperties so that they are only available to Presto-on-Spark
Also, we move out the existing property
native_execution_process_reuse_enabledto PrestoOnSparkSessionProperties well, as this too is a Presto-on-Spark specific property
Motivation and Context
We need these session properties for PoS Native
Impact
Test Plan
CI/Unit tests
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.