Delete native_execution_enabled/executable_path/program_arguments session properties#22183
Merged
mbasmanova merged 1 commit intoprestodb:masterfrom Mar 27, 2024
Merged
Conversation
amitkdutta
previously approved these changes
Mar 13, 2024
Contributor
amitkdutta
left a comment
amitkdutta
left a comment
There was a problem hiding this comment.
Looks good. Thanks @mbasmanova
6 tasks
tdcmeehan
previously approved these changes
Mar 22, 2024
Contributor
|
Thank you! |
…sion properties These are no longer used.
mbasmanova
force-pushed
the
del-native-exec
branch
from
06c8741 to
ee698f5
Compare
Contributor
Author
|
@tdcmeehan Tim, I needed to rebase this PR. Can you approve again? |
tdcmeehan
approved these changes
Mar 27, 2024
Contributor
Author
|
@tdcmeehan Thank you, Tim. |
48 tasks
shrinidhijoshi
added a commit
to shrinidhijoshi/presto
that referenced
this pull request
Jul 15, 2025
This diff re-introduces 2 session properties - native_execution_executable_path, - native_execution_program_arguments deleted as a part of prestodb#22183. But these are introduced in the PrestoOnSparkSessionProperties so that they are only available to Presto-on-Spark Also, we move out the existing property `native_execution_process_reuse_enabled` to the same location as well, as this too is a Presto-on-Spark specific property
6 tasks
shrinidhijoshi
added a commit
to shrinidhijoshi/presto
that referenced
this pull request
Jul 15, 2025
This diff re-introduces 2 session properties - native_execution_executable_path, - native_execution_program_arguments deleted as a part of prestodb#22183. But these are introduced in the PrestoOnSparkSessionProperties so that they are only available to Presto-on-Spark Also, we move out the existing property `native_execution_process_reuse_enabled` to the same location as well, as this too is a Presto-on-Spark specific property
shrinidhijoshi
added a commit
to shrinidhijoshi/presto
that referenced
this pull request
Jul 15, 2025
This diff re-introduces 2 session properties - native_execution_executable_path, - native_execution_program_arguments deleted as a part of prestodb#22183. But these are introduced in the PrestoOnSparkSessionProperties so that they are only available to Presto-on-Spark Also, we move out the existing property `native_execution_process_reuse_enabled` to the same location as well, as this too is a Presto-on-Spark specific property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are no longer used.