Skip to content

Handle binary varying type for newer redshift driver #25488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agrawalreetika merged 1 commit into from
Jul 8, 2025
Merged

Handle binary varying type for newer redshift driver #25488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions presto-redshift/src/main/java/com/facebook/presto/plugin/redshift/RedshiftClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
import com.facebook.presto.plugin.jdbc.DriverConnectionFactory;
import com.facebook.presto.plugin.jdbc.JdbcConnectorId;
import com.facebook.presto.plugin.jdbc.JdbcIdentity;
import com.facebook.presto.plugin.jdbc.JdbcTypeHandle;
import com.facebook.presto.plugin.jdbc.ReadMapping;
import com.facebook.presto.spi.ConnectorSession;
import com.facebook.presto.spi.PrestoException;
import com.facebook.presto.spi.SchemaTableName;
Expand All @@ -28,8 +30,10 @@
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.util.Optional;

import static com.facebook.presto.plugin.jdbc.JdbcErrorCode.JDBC_ERROR;
import static com.facebook.presto.plugin.jdbc.StandardReadMappings.varbinaryReadMapping;
import static java.lang.String.format;

public class RedshiftClient
Expand Down Expand Up @@ -66,4 +70,17 @@ protected void renameTable(JdbcIdentity identity, String catalogName, SchemaTabl
throw new PrestoException(JDBC_ERROR, e);
}
}

// Maps "binary varying" (Redshift driver >= 2.1.0.32) to VARBINARY.
@Override
public Optional<ReadMapping> toPrestoType(ConnectorSession session, JdbcTypeHandle typeHandle)
{
String typeName = typeHandle.getJdbcTypeName();

if (typeName.equalsIgnoreCase("binary varying")) {
Copy link
Contributor

@tdcmeehan tdcmeehan Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining that this is dependent on the version of the driver, as is included in this PR?

Copy link
Contributor Author

@adkharat adkharat Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdcmeehan 1 line comment added.

or do you want me to add comment in Javadoc-style format

/**
 * Maps Redshift VARBYTE columns to Presto VARBINARY.
 * <p>
 * Redshift JDBC driver version ≥ 2.1.0.32 reports VARBYTE as JDBC type 1111 (Types.OTHER)
 * with type name "binary varying", whereas older versions (e.g., 2.1.0.28) report it
 * as type -4 (Types.LONGVARBINARY) with type name "varbyte".
 * This mapping ensures compatibility with newer driver versions.
 */

return Optional.of(varbinaryReadMapping());
}

return super.toPrestoType(session, typeHandle);
}
}
Loading