Handle binary varying type for newer redshift driver

[adkharat]

Description

Redshift driver version is 2.1.0.32

JdbcTypeHandle {
   jdbcType=1111, 
   jdbcTypeName=binary varying, 
   columnSize=2147483647, 
   decimalDigits=0
}

Redshift driver version is 2.1.0.28

JdbcTypeHandle {
    jdbcType = -4,
    jdbcTypeName = "varbyte",
    columnSize = 0,
    decimalDigits = 0,
    arrayDimensions = null
}

Newer redshift drivers uses Types.OTHER (1111) to represent VARBYTE and describes it as "binary varying"

JDBC Driver Version	Reported JDBC Type	JDBC Type Name
2.1.0.28	-4 (LONGVARBINARY)	"varbyte"
2.1.0.32	1111 (OTHER)	"binary varying"

Motivation and Context

create table redshift.test.redtest4 (varbincolumn varbinary);

The Redshift JDBC driver returns the JDBC type for VARBYTE columns as:
JdbcTypeHandle{jdbcType=1111, jdbcTypeName=binary varying, columnSize=2147483647, decimalDigits=0}

This type is not recognized by Presto's default jdbcTypeToPrestoType() mapping,
resulting in the column being ignored as unsupported during DESCRIBE or INSERT queries

DESCRIBE redshift.test.redtest1; output is:

presto> DESCRIBE redshift.test.redtest1;
 Column | Type | Extra | Comment 
--------+------+-------+---------
(0 rows)

Query 20250626_070357_00001_29zdf, FINISHED, 1 node
Splits: 19 total, 19 done (100.00%)
[Latency: client-side: 0:36, server-side: 0:36] [0 rows, 0B] [0 rows/s, 0B/s]

SHOW CREATE TABLE redshift.test.redtest1; output is:

presto> SHOW CREATE TABLE redshift.test.redtest1;
Query 20250626_070441_00002_29zdf failed: Table 'test.redtest1' has no supported columns (all 1 columns are not supported)

INSERT query output is:

presto> insert into redshift.test.redtest1 (varbincolumn) values (cast('Test varbinary' as varbinary));
Query 20250626_071129_00006_29zdf failed: Table 'test.redtest1' has no supported columns (all 1 columns are not supported)

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Redshift Connector Changes
* Fix Redshift VARBYTE column handling for JDBC driver version 2.1.0.32+ by mapping jdbcType=1111 and jdbcTypeName="binary varying" to Presto's VARBINARY type.

[agrawalreetika]

Changes LGTM.
Please update the commit message with -

Handle binary varying type introduced in newer Redshift drivers

[adkharat]

@tdcmeehan can you please review and the merge this PR?

[tdcmeehan]

Can you add a comment explaining that this is dependent on the version of the driver, as is included in this PR?

[adkharat]

@tdcmeehan 1 line comment added.

or do you want me to add comment in Javadoc-style format

/**
 * Maps Redshift VARBYTE columns to Presto VARBINARY.
 * <p>
 * Redshift JDBC driver version ≥ 2.1.0.32 reports VARBYTE as JDBC type 1111 (Types.OTHER)
 * with type name "binary varying", whereas older versions (e.g., 2.1.0.28) report it
 * as type -4 (Types.LONGVARBINARY) with type name "varbyte".
 * This mapping ensures compatibility with newer driver versions.
 */