Add a JDBC write mapping interface#25437
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Jul 14, 2025
Merged
Conversation
prestodb-ci
requested review from
a team,
bibith4 and
wanglinsong
and removed request for
a team
Contributor
|
@infvg Did we have a discussion with Meta people around this? Are they fine with it this time? |
infvg
force-pushed
the
writemapping
branch
3 times, most recently
from
c7b3afd to
4f4b59a
Compare
Contributor
|
Thanks for the release note entry! Consider adding a little explanation of how what benefit this gives. |
Contributor
|
More context of this PR: it is an update from #25124 which was reverted in #25369. The difference is that instead of replacing ReadMapping class with ColumnMapping (as in #25124), this PR keeps ReadMapping. So now we have ReadMapping+WriteMapping which makes the code structure more intuitive. This change was done after our offline discussion on the approach to address the original motivation. |
infvg
force-pushed
the
writemapping
branch
2 times, most recently
from
2d351d4 to
8978d9c
Compare
zation99
previously approved these changes
Jul 1, 2025
zation99
reviewed
Jul 2, 2025
|
|
||
| /* | ||
| * JDBC based connectors can control how data should be read from a ResultSet via ReadMapping definitions. But writing was | ||
| * hard-coded in JdbcPageSink#appendColumn. This class provides the control to define how data should be written back to |
Contributor
There was a problem hiding this comment.
the comment seems should be in WriteMapping class.
Contributor
Author
There was a problem hiding this comment.
Added a comment for both classes
Contributor
|
@ethanyzhang imported this issue as lakehouse/presto #25437 |
Co-authored-by: pratyakshsharma <pratyaksh13@gmail.com>
rschlussel
approved these changes
Jul 14, 2025
6 tasks
shangm2
added a commit
that referenced
this pull request
Jul 15, 2025
## Description 1. Build fails on master branch due to #25437 2. Newly created pr failed <img width="1034" height="204" alt="Screenshot 2025-07-14 at 14 32 35" src="https://github.com/user-attachments/assets/b15b07dc-5232-46f0-8dc0-e17005996c0f" /> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
6 tasks
This was referenced Jul 24, 2025
6 tasks
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 2, 2025
## Description 1. Build fails on master branch due to prestodb#25437 2. Newly created pr failed <img width="1034" height="204" alt="Screenshot 2025-07-14 at 14 32 35" src="https://github.com/user-attachments/assets/b15b07dc-5232-46f0-8dc0-e17005996c0f" /> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description 1. Build fails on master branch due to prestodb#25437 2. Newly created pr failed <img width="1034" height="204" alt="Screenshot 2025-07-14 at 14 32 35" src="https://github.com/user-attachments/assets/b15b07dc-5232-46f0-8dc0-e17005996c0f" /> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description 1. Build fails on master branch due to prestodb#25437 2. Newly created pr failed <img width="1034" height="204" alt="Screenshot 2025-07-14 at 14 32 35" src="https://github.com/user-attachments/assets/b15b07dc-5232-46f0-8dc0-e17005996c0f" /> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description 1. Build fails on master branch due to prestodb#25437 2. Newly created pr failed <img width="1034" height="204" alt="Screenshot 2025-07-14 at 14 32 35" src="https://github.com/user-attachments/assets/b15b07dc-5232-46f0-8dc0-e17005996c0f" /> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description 1. Build fails on master branch due to prestodb#25437 2. Newly created pr failed <img width="1034" height="204" alt="Screenshot 2025-07-14 at 14 32 35" src="https://github.com/user-attachments/assets/b15b07dc-5232-46f0-8dc0-e17005996c0f" /> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description 1. Build fails on master branch due to prestodb#25437 2. Newly created pr failed <img width="1034" height="204" alt="Screenshot 2025-07-14 at 14 32 35" src="https://github.com/user-attachments/assets/b15b07dc-5232-46f0-8dc0-e17005996c0f" /> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
lga-zurich
pushed a commit
to lga-zurich/presto-exchange
that referenced
this pull request
Sep 8, 2025
## Description 1. Build fails on master branch due to prestodb#25437 2. Newly created pr failed <img width="1034" height="204" alt="Screenshot 2025-07-14 at 14 32 35" src="https://github.com/user-attachments/assets/b15b07dc-5232-46f0-8dc0-e17005996c0f" /> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, write mapping is hard coded in JdbcPageSink.appendColumn, making it difficult to add additional write support. This PR adds WriteMapping to match the ReadMapping functionality & make it possible to add additional type support on a per connector basis.
Motivation and Context
It will allow us to support additional types on a per connector basis
Impact
None
Test Plan
Unit tests
Contributor checklist
Release Notes