Extended readMapping to columnMapping for jdbc connectors#17972
Closed
pratyakshsharma wants to merge 1 commit intoprestodb:masterfrom
Closed
Extended readMapping to columnMapping for jdbc connectors#17972pratyakshsharma wants to merge 1 commit intoprestodb:masterfrom
pratyakshsharma wants to merge 1 commit intoprestodb:masterfrom
Conversation
Contributor
Author
|
@NikhilCollooru gentle ping! |
Contributor
Author
|
@imjalpreet @agrawalreetika @fgwang7w Can you guys take the first pass here? |
Contributor
|
Can you revisit this? @pratyakshsharma |
Contributor
Author
|
@agrawalreetika Let us revive this? |
b74d9ec to
9ae7f2c
Compare
Contributor
Author
|
@agrawalreetika I have resolved the conflicts. |
Member
|
Thank you @pratyakshsharma for raising the PR. I see there are multiple changes done in this PR. Could we break it into feature-wise commits? It would also make it easier to review |
Member
|
@pratyakshsharma Is this still a valid PR? |
Contributor
Author
|
can be closed now in favour of #25437 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently jdbc connectors control how the data should be read using ReadMapping. But the writing is hard coded in JdbcPageSink#appendColumn. Below are some of the requirements which require proper writeMapping and inclusion of write functions with read mapping (or a generic ColumnMapping) -
All this requires us to introduce a new WriteMapping for writing data to storage. ReadMapping needs to be extended into ColumnMapping which will also contain WriteFunctions. A new WriteFunction interface needs to be introduced.
Ref: #12151
Test plan - (Please fill in how you tested your changes)
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.