Move UnnestNode to SPI and add to collector optimizer#25317
Merged
feilong-liu merged 1 commit intoprestodb:masterfrom Jun 26, 2025
Merged
Move UnnestNode to SPI and add to collector optimizer#25317feilong-liu merged 1 commit intoprestodb:masterfrom
feilong-liu merged 1 commit intoprestodb:masterfrom
Conversation
feilong-liu
force-pushed
the
unnest_connector
branch
8 times, most recently
from
d53aca1 to
49def2b
Compare
feilong-liu
commented
Jun 14, 2025
| } // namespace facebook::presto::protocol::hive | ||
| namespace facebook::presto::protocol::hive { | ||
| struct Table { | ||
| std::shared_ptr<String> catalogName = {}; |
Contributor
Author
There was a problem hiding this comment.
No idea what this is, but this is what the tool generated running make presto_protocol
| - { name: TopNNode, key: .TopNNode } | ||
| - { name: TopNRowNumberNode, key: com.facebook.presto.sql.planner.plan.TopNRowNumberNode } | ||
| - { name: UnnestNode, key: com.facebook.presto.sql.planner.plan.UnnestNode } | ||
| - { name: UnnestNode, key: .UnnestNode } |
Contributor
Author
There was a problem hiding this comment.
protocol change
| - { name: TopNNode, key: .TopNNode } | ||
| - { name: TopNRowNumberNode, key: com.facebook.presto.sql.planner.plan.TopNRowNumberNode } | ||
| - { name: UnnestNode, key: com.facebook.presto.sql.planner.plan.UnnestNode } | ||
| - { name: UnnestNode, key: .UnnestNode } |
Contributor
Author
There was a problem hiding this comment.
protocol change
| @Immutable | ||
| public class UnnestNode | ||
| extends InternalPlanNode | ||
| public final class UnnestNode |
Contributor
Author
There was a problem hiding this comment.
main change in this file
rschlussel
approved these changes
Jun 16, 2025
hantangwangd
approved these changes
Jun 16, 2025
gggrace14
approved these changes
Jun 26, 2025
feilong-liu
force-pushed
the
unnest_connector
branch
from
49def2b to
9e8fbbd
Compare
Contributor
|
Thanks for the release note entry! Nit: suggest revising the entry to begin with one of the keywords in the Order of changes of the Release Notes Guidelines. Maybe something like this? |
This was referenced Jul 4, 2025
This was referenced Jul 24, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move UnnestNode to SPI, so that it can be used in connector optimizer. Similar to #24088
Most part of the change is refactoring the import path for this node. Meaningful change is to get rid of functions not available in SPI, mainly Guava libraries, and replace them with java builtin collection methods.
Motivation and Context
Impact
Make UnnestNode available in connector optimizer
Test Plan
Existing unit tests
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.