Revert #25245 Move Bootstrap.class to presto-bytecode to avoid duplicate definitions #25260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D76145724 |
Contributor
|
What is D75970190 and presto-Facebook? |
shelton408
pushed a commit
to shelton408/presto
that referenced
this pull request
Jun 6, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
shelton408
force-pushed
the
export-D76145724
branch
from
c398977 to
b1fb91d
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D76145724 |
shelton408
changed the title
Contributor
Author
Updated description. |
shelton408
changed the title
shelton408
pushed a commit
to shelton408/presto
that referenced
this pull request
Jun 6, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
shelton408
force-pushed
the
export-D76145724
branch
from
b1fb91d to
f0b168c
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D76145724 |
Contributor
|
please add a description/example stacktrace for the failures. |
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
shelton408
force-pushed
the
export-D76145724
branch
from
f0b168c to
c10b30d
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D76145724 |
shelton408
added a commit
to shelton408/presto
that referenced
this pull request
Jun 8, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
rschlussel
approved these changes
Jun 9, 2025
shelton408
added a commit
to shelton408/presto
that referenced
this pull request
Jun 9, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
6 tasks
rschlussel
pushed a commit
that referenced
this pull request
Jun 9, 2025
…initions [D75970190] (#25260) Summary: This diff reverts D75970190 Reverts #25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
rschlussel
pushed a commit
that referenced
this pull request
Jun 13, 2025
…initions [D75970190] (#25260) Summary: This diff reverts D75970190 Reverts #25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
6 tasks
anandamideShakyan
pushed a commit
to anandamideShakyan/presto
that referenced
this pull request
Jun 19, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
12 tasks
This was referenced Jul 10, 2025
This was referenced Jul 24, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts #25245
Internal pr: D75970190
Causing errors for aggregation UDF's e.g.
Caused by: java.lang.IllegalArgumentException: Expected com.facebook.presto.$gen.WeightedAverageStateSerializer_20250605_114214_4193's classloader to be of type com.facebook.presto.bytecode.DynamicClassLoader, but is com.facebook.presto.bytecode.DynamicClassLoader
Initial investigation suggests we're missing a safe class loader somewhere, unknown whether we're missing this in OSS or in facebook internal code.
Motivation and Context
Commit is causing issues in facebooks internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with our internal release while we look into the issue.
Impact
Revert code move, any other class
Test Plan
Build to cluster and pass the failed queries
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.