-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Move Bootstrap.class to presto-bytecode to avoid duplicate definitions #25245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hantangwangd
merged 1 commit into
prestodb:master
from
hantangwangd:refactor_bootstrap_for_codegen
Jun 4, 2025
Merged
Move Bootstrap.class to presto-bytecode to avoid duplicate definitions #25245
hantangwangd
merged 1 commit into
prestodb:master
from
hantangwangd:refactor_bootstrap_for_codegen
Jun 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacBlanco
approved these changes
Jun 4, 2025
shelton408
pushed a commit
to shelton408/presto
that referenced
this pull request
Jun 6, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
6 tasks
shelton408
pushed a commit
to shelton408/presto
that referenced
this pull request
Jun 6, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
shelton408
added a commit
to shelton408/presto
that referenced
this pull request
Jun 7, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
shelton408
added a commit
to shelton408/presto
that referenced
this pull request
Jun 8, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
shelton408
added a commit
to shelton408/presto
that referenced
this pull request
Jun 9, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
6 tasks
rschlussel
pushed a commit
that referenced
this pull request
Jun 9, 2025
…initions [D75970190] (#25260) Summary: This diff reverts D75970190 Reverts #25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
rschlussel
pushed a commit
that referenced
this pull request
Jun 12, 2025
…initions [D75970190] (#25260) Summary: This diff reverts D75970190 Reverts #25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
rschlussel
pushed a commit
that referenced
this pull request
Jun 13, 2025
…initions [D75970190] (#25260) Summary: This diff reverts D75970190 Reverts #25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
6 tasks
anandamideShakyan
pushed a commit
to anandamideShakyan/presto
that referenced
this pull request
Jun 19, 2025
…initions [D75970190] (prestodb#25260) Summary: This diff reverts D75970190 Reverts prestodb#25245 Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue. Depends on D75970190 Differential Revision: D76145724
This was referenced Jul 4, 2025
This was referenced Jul 24, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, due to maven dependency issues, the
Bootstrap.classused to implement bootstrap method forinvokedynamicsupporting is defined separately in bothpresto-hive-function-namespaceandpresto-main-base. Ideally, it should be defined together withCallSiteBinderin modulepresto-bytecode, which would also resolve the issue thatpresto-main-baseandpresto-hive-function-namespacecannot see each other, thus eliminating the need to defineBootstrap.classseparately in both modules.So, this PR moved
Bootstrap.classto modulepresto-bytecode, this way, deleted the duplicate definitions in other places.Motivation and Context
Refactor to avoid duplicated class definitions
Impact
N/A
Test Plan
Contributor checklist
Release Notes