Skip to content

Conversation

@hantangwangd
Copy link
Member

@hantangwangd hantangwangd commented Jun 4, 2025

Description

Currently, due to maven dependency issues, the Bootstrap.class used to implement bootstrap method for invokedynamic supporting is defined separately in both presto-hive-function-namespace and presto-main-base. Ideally, it should be defined together with CallSiteBinder in module presto-bytecode, which would also resolve the issue that presto-main-base and presto-hive-function-namespace cannot see each other, thus eliminating the need to define Bootstrap.class separately in both modules.

So, this PR moved Bootstrap.class to module presto-bytecode, this way, deleted the duplicate definitions in other places.

Motivation and Context

Refactor to avoid duplicated class definitions

Impact

N/A

Test Plan

  • Make sure this refactor do not affect existing CI tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@hantangwangd hantangwangd marked this pull request as ready for review June 4, 2025 06:40
@hantangwangd hantangwangd requested a review from a team as a code owner June 4, 2025 06:40
@hantangwangd hantangwangd requested a review from jaystarshot June 4, 2025 06:40
@hantangwangd hantangwangd merged commit a7681b6 into prestodb:master Jun 4, 2025
105 checks passed
@hantangwangd hantangwangd deleted the refactor_bootstrap_for_codegen branch June 4, 2025 16:57
shelton408 pushed a commit to shelton408/presto that referenced this pull request Jun 6, 2025
…initions [D75970190] (prestodb#25260)

Summary:

This diff reverts D75970190
Reverts prestodb#25245
Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue.

Depends on D75970190

Differential Revision: D76145724
shelton408 pushed a commit to shelton408/presto that referenced this pull request Jun 6, 2025
…initions [D75970190] (prestodb#25260)

Summary:

This diff reverts D75970190
Reverts prestodb#25245
Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue.

Depends on D75970190

Differential Revision: D76145724
shelton408 added a commit to shelton408/presto that referenced this pull request Jun 7, 2025
…initions [D75970190] (prestodb#25260)

Summary:

This diff reverts D75970190
Reverts prestodb#25245
Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue.

Depends on D75970190

Differential Revision: D76145724
shelton408 added a commit to shelton408/presto that referenced this pull request Jun 8, 2025
…initions [D75970190] (prestodb#25260)

Summary:

This diff reverts D75970190
Reverts prestodb#25245
Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue.

Depends on D75970190

Differential Revision: D76145724
shelton408 added a commit to shelton408/presto that referenced this pull request Jun 9, 2025
…initions [D75970190] (prestodb#25260)

Summary:

This diff reverts D75970190
Reverts prestodb#25245
Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue.

Depends on D75970190

Differential Revision: D76145724
rschlussel pushed a commit that referenced this pull request Jun 9, 2025
…initions [D75970190] (#25260)

Summary:

This diff reverts D75970190
Reverts #25245
Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue.

Depends on D75970190

Differential Revision: D76145724
rschlussel pushed a commit that referenced this pull request Jun 12, 2025
…initions [D75970190] (#25260)

Summary:

This diff reverts D75970190
Reverts #25245
Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue.

Depends on D75970190

Differential Revision: D76145724
rschlussel pushed a commit that referenced this pull request Jun 13, 2025
…initions [D75970190] (#25260)

Summary:

This diff reverts D75970190
Reverts #25245
Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue.

Depends on D75970190

Differential Revision: D76145724
anandamideShakyan pushed a commit to anandamideShakyan/presto that referenced this pull request Jun 19, 2025
…initions [D75970190] (prestodb#25260)

Summary:

This diff reverts D75970190
Reverts prestodb#25245
Causing issues in our facebook internal verifier. Not sure if issue is with facebook internal, or oss spi. Temporary revert so we can continue with release while we attempt to fix the issue.

Depends on D75970190

Differential Revision: D76145724
@prestodb-ci prestodb-ci mentioned this pull request Jul 28, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants