[Iceberg]Support rename view on Rest catalog and Nessie catalog#25202
Conversation
| ((ViewCatalog) catalog).renameView( | ||
| toIcebergTableIdentifier(source, catalogFactory.isNestedNamespaceEnabled()), | ||
| toIcebergTableIdentifier(target, catalogFactory.isNestedNamespaceEnabled())); | ||
| } |
There was a problem hiding this comment.
One question here, do we need to catch NoSuchNamespaceException here?
There was a problem hiding this comment.
I think there is no need to check and catch NoSuchNamespaceException here again because the check is already done in RenameViewTask. See the comment in IcebergHiveMetadata here. Do you think this makes sense?
There was a problem hiding this comment.
So as per Iceberg API it could throw these 3 exception here. And as I checked earlier, RenameViewTask checks for first two?
There was a problem hiding this comment.
Thanks for your detailed message. After re-checking the code, I think we needn't consider the situation that would throw a NoSuchNamespaceException, since we do not allow view rename cross schemas or catalogs, see here.
agrawalreetika
left a comment
There was a problem hiding this comment.
Mostly LGTM. Just one question.
agrawalreetika
left a comment
There was a problem hiding this comment.
Thanks for the change. LGTM
Description
Through PR #23749 we support
ALTER VIEW RENAME TOstatement, and support rename view for Iceberg connector configured with Hive catalog. This PR enables catalogs likeRESTandNESSIEthat implements interfaceViewCatalogto supportrename viewas well.Motivation and Context
Support
rename viewfor Iceberg connector on as many catalog types as possibleImpact
Iceberg connector configured with
RESTandNESSIEcatalogs can now support rename viewTest Plan
Contributor checklist
Release Notes