Add support for ALTER VIEW RENAME TO statement#23749
Add support for ALTER VIEW RENAME TO statement#23749tdcmeehan merged 3 commits intoprestodb:masterfrom
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e416ff1...5a61649.
|
|
Consider adding documentation for this to https://prestodb.io/docs/current/connector/iceberg.html#sql-support. |
6f20ada to
cae013d
Compare
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
|
Thanks for the PR. I have a few suggestions -
|
presto-main/src/main/java/com/facebook/presto/execution/RenameViewTask.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/RenameViewTask.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/testing/LocalQueryRunner.java
Outdated
Show resolved
Hide resolved
c3a6ed6 to
b1a2ab6
Compare
|
@dmariamgeorge Can we split this into two commits like @agrawalreetika suggested? Once we have both commits I will also review |
|
Minor nits of formatting suggested for the release note entry. |
Sure @ZacBlanco. Working on the same. |
4f1282b to
4cbfaee
Compare
@ZacBlanco - I have split the commits as suggested by @agrawalreetika. Can you please take a look? |
10ad8f2 to
6475420
Compare
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the updated doc! Two minor rephrasing suggestions.
5a61649
6475420 to
5a61649
Compare
|
Hi @ZacBlanco @agrawalreetika @steveburnett @hantangwangd Could you please take another look at this PR? I’ve incorporated all the review comments. Thanks! |
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated build, new local doc build, reviewed pages in local doc build. Everything looks good. Thanks!
|
@dmariamgeorge instead of the screenshot in the PR description under "Test Plan", can you please replace it with a short summary of the unit and integration tests that have been added |
|
Also, I suggest in the release note section to be more specific in the "General Changes" section that we're adding the ability for connectors to implement |
|
@ZacBlanco - I have revised the PR description. Could you please review it? |
|
Hi @tdcmeehan I have received approvals from @ZacBlanco, @agrawalreetika, @hantangwangd, and @steveburnett on this PR. Could you please help merge this PR? Thanks! |
Description
Add support for SQL statement ALTER VIEW <view_name> RENAME TO <new_view_name>.
Motivation and Context
Addresses issue: #23748
Impact
Support SQL statement ALTER VIEW <view_name> RENAME TO <new_view_name> in Iceberg connector.
Test Plan
testTableRules()inTestFileBasedAccessControl.javato include check for rename view.testRenameView()inTestSqlParser.java.testRenameView()andtestRenameViewIfNotExists()inTestMemorySmoke.java.testViews()inTestMemoryMetadata.javato include check for rename view.testRenameView()andtestRenameViewIfNotExists()inTestIcebergMetadataListing.java.Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.