Skip to content

[DNR] Test for first pr.#25181

Closed
KIRITOLTR wants to merge 3 commits intoprestodb:masterfrom
KIRITOLTR:master
Closed

[DNR] Test for first pr.#25181
KIRITOLTR wants to merge 3 commits intoprestodb:masterfrom
KIRITOLTR:master

Conversation

@KIRITOLTR
Copy link
Contributor

Description

Adding some simple examples for functions in aggregate.rst.

Motivation and Context

For addressing the lack of working examples in functions docs. See #19830

Impact

Documentation.

Test Plan

Local doc builds. Some Screeshot:
c0e67e3d-ed4f-464e-a43d-bab573d93372

badbf4f8-6129-498e-8560-cd50d5eb617a

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
== NO RELEASE NOTE ==

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@KIRITOLTR
Copy link
Contributor Author

Hi, @steveburnett. Seems like there is a building problem in presto-docs module. How to solve this check failure for now? Referrence here #25178.

@steveburnett
Copy link
Contributor

Hi, @steveburnett. Seems like there is a building problem in presto-docs module. How to solve this check failure for now? Referrence here #25178.

Fix has been merged, and the test is now passing - see #25188 for an example. Rebase your PR to re-run the CI tests and docs / test (:presto-docs) (pull_request) should pass for this PR as well.

@KIRITOLTR KIRITOLTR closed this by deleting the head repository May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🆕 Unprioritized

Development

Successfully merging this pull request may close these issues.

2 participants