Fix a build issue in presto-docs#25178
Conversation
|
why didn't this fail in the CI before? |
tdcmeehan
left a comment
There was a problem hiding this comment.
Both should work, but I'm OK with this. Would be good to understand why it's a problem now.
hantangwangd
left a comment
There was a problem hiding this comment.
Lgtm, the build fails in my local without this fix.
It seems that the standard thrift syntax specification requires using commas(,) rather than semicolons(;) as separators between enum values. I guess both cases can build successfully may because the thrift compiler or toolchain used in local has implemented syntax compatibility handling.
|
Thanks for your review! The reason is there's an update of drift yesterday (v1.43). And for method |
|
Rebasing and merging this now, based on the three approving reviews. |
|
Description
This PR fixes a build issue in
presto-docsMotivation and Context
Previously, we got a build failure in
presto-docsas described in #25177. This PR fixes it.Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.