Skip to content

Add requestDataSizesMaxWaitSec to Prestissimo system configs #24774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeidiHan0000 merged 1 commit into from
Mar 28, 2025
Merged

Add requestDataSizesMaxWaitSec to Prestissimo system configs #24774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions presto-docs/src/main/sphinx/presto_cpp/properties.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Presto C++ Configuration Properties
===================================

This section describes Presto C++ configuration properties.
This section describes Presto C++ configuration properties.

The following is not a complete list of all configuration properties,
and does not include any connector-specific catalog configuration properties
Expand Down Expand Up @@ -429,7 +429,7 @@ The configuration properties of AsyncDataCache and SSD cache are described here.
* **Type:** ``integer``
* **Default value:** ``0``

The size of the SSD. Unit is in GiB (gibibytes).
The size of the SSD. Unit is in GiB (gibibytes).

``async-cache-ssd-path``
^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down Expand Up @@ -529,6 +529,17 @@ The configuration properties of AsyncDataCache and SSD cache are described here.

The periodic duration to apply cache TTL and evict AsyncDataCache and SSD cache entries.

Exchange Properties
-------------------

``exchange.http-client.request-data-sizes-max-wait-sec``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

* **Type:** ``integer``
* **Default value:** ``10``

Maximum wait time for exchange request in seconds.

Memory Checker Properties
-------------------------

Expand Down
5 changes: 5 additions & 0 deletions presto-native-execution/presto_cpp/main/common/Configs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ SystemConfig::SystemConfig() {
BOOL_PROP(kJoinSpillEnabled, true),
BOOL_PROP(kAggregationSpillEnabled, true),
BOOL_PROP(kOrderBySpillEnabled, true),
NUM_PROP(kRequestDataSizesMaxWaitSec, 10),
};
}

Expand Down Expand Up @@ -333,6 +334,10 @@ bool SystemConfig::orderBySpillEnabled() const {
return optionalProperty<bool>(kOrderBySpillEnabled).value();
}

int SystemConfig::requestDataSizesMaxWaitSec() const {
return optionalProperty<int>(kRequestDataSizesMaxWaitSec).value();
}

bool SystemConfig::mutableConfig() const {
return optionalProperty<bool>(kMutableConfig).value();
}
Expand Down
6 changes: 6 additions & 0 deletions presto-native-execution/presto_cpp/main/common/Configs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,10 @@ class SystemConfig : public ConfigBase {
static constexpr std::string_view kOrderBySpillEnabled{
"order-by-spill-enabled"};

// Max wait time for exchange request in seconds.
static constexpr std::string_view kRequestDataSizesMaxWaitSec{
"exchange.http-client.request-data-sizes-max-wait-sec"};

SystemConfig();

virtual ~SystemConfig() = default;
Expand Down Expand Up @@ -983,6 +987,8 @@ class SystemConfig : public ConfigBase {
bool aggregationSpillEnabled() const;

bool orderBySpillEnabled() const;

int requestDataSizesMaxWaitSec() const;
};

/// Provides access to node properties defined in node.properties file.
Expand Down
Loading