Add requestDataSizesMaxWaitSec to Prestissimo system configs#24774
Add requestDataSizesMaxWaitSec to Prestissimo system configs#24774HeidiHan0000 merged 1 commit intoprestodb:masterfrom
Conversation
HeidiHan0000
requested review from
a team,
elharo and
steveburnett
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D71572165 |
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc! Just one nit.
kewang1024
left a comment
kewang1024
left a comment
There was a problem hiding this comment.
Thanks @HeidiHan0000 for making the changes
|
|
||
| // Max wait time for exchange request in seconds. | ||
| static constexpr std::string_view kRequestDataSizesMaxWaitSec{ | ||
| "request-data-sizes-max-wait-sec"}; |
There was a problem hiding this comment.
Can we change it to exchange.http-client.request-data-sizes-max-wait-sec
|
|
||
| The periodic duration to apply cache TTL and evict AsyncDataCache and SSD cache entries. | ||
|
|
||
| ``request-data-sizes-max-wait-sec`` |
There was a problem hiding this comment.
Add a new categorization?
Exchange Properties
----------------
…b#24774) Summary: as title Differential Revision: D71572165
HeidiHan0000
force-pushed
the
export-D71572165
branch
from
4d236fb to
8751cbf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71572165 |
…b#24774) Summary: as title Differential Revision: D71572165
HeidiHan0000
force-pushed
the
export-D71572165
branch
from
8751cbf to
2f7ff73
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71572165 |
…b#24774) Summary: as title Differential Revision: D71572165
HeidiHan0000
force-pushed
the
export-D71572165
branch
from
2f7ff73 to
fc49424
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71572165 |
…b#24774) Summary: Pull Request resolved: prestodb#24774 as title Differential Revision: D71572165
HeidiHan0000
force-pushed
the
export-D71572165
branch
from
fc49424 to
0304cda
Compare
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
A nit of formatting that I overlooked in yesterday's review. Sorry about that!
| {core::QueryConfig::kRequestDataSizesMaxWaitSec, | ||
| std::string(SystemConfig::kRequestDataSizesMaxWaitSec)}}; |
There was a problem hiding this comment.
I would suggest leaving the session property change to next PR together with java side change, and we should move this to SessionProperties which is the centralized place for placing session property
| {"aggregation_spill_all", "true"}, | ||
| {"native_expression_max_array_size_in_reduce", "99999"}, | ||
| {"native_expression_max_compiled_regexes", "54321"}, | ||
| {"request_data_sizes_max_wait_sec", "20"}, |
There was a problem hiding this comment.
We can leave the session property change to next PR
…b#24774) Summary: as title Differential Revision: D71572165
HeidiHan0000
force-pushed
the
export-D71572165
branch
from
0304cda to
e75cd03
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71572165 |
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
…b#24774) (prestodb#24774) Summary: as title Differential Revision: D71572165
5 participants
Summary: as title
Differential Revision: D71572165