Skip to content

Update security protocol to TLS#24474

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
ShahimSharafudeen:static_issues_jan
Feb 6, 2025
Merged

Update security protocol to TLS#24474
tdcmeehan merged 1 commit intoprestodb:masterfrom
ShahimSharafudeen:static_issues_jan

Conversation

@ShahimSharafudeen
Copy link
Contributor

@ShahimSharafudeen ShahimSharafudeen commented Feb 3, 2025

Description

  1. CWE: Weak SSL/TLS protocols should not be used

SSLContext result = SSLContext.getInstance("TLS"); // Automatically selects the best supported version

Reference PR : #24436

Motivation and Context

Enhanced Security Protocol to TLS"SSL" uses older and insecure protocols such as SSLv2 and SSLv3, which are vulnerable to attacks like POODLE.
"TLSv1.2" make use of the more modern and secure TLS 1.2 protocol, which mitigates known vulnerabilities in earlier versions of SSL/TLS.

Impact

Backward Compatibility:
If the client does not support TLS 1.2 (e.g., very old systems or devices), the connection may fail.

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Elastic search Changes
* Improve cryptographic protocol in response to `java:S4423 <https://sonarqube.ow2.org/coding_rules?open=java%3AS4423&rule_key=java%3AS4423>`_.

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 3, 2025
@ShahimSharafudeen ShahimSharafudeen changed the title Update security protocol to TLS and change cipher mode padding Update security protocol to TLS Feb 4, 2025
@ShahimSharafudeen ShahimSharafudeen marked this pull request as ready for review February 4, 2025 06:45
@ShahimSharafudeen ShahimSharafudeen requested a review from a team as a code owner February 4, 2025 06:45
@steveburnett
Copy link
Contributor

New release note guidelines. Please remove the manual PR link in the following format from the release note entries for this PR.

:pr:`12345`

I have updated the Release Notes Guidelines to remove the examples of manually adding the PR link.

@ShahimSharafudeen
Copy link
Contributor Author

Release Notes Guidelines

@steveburnett - Updated the Release Notes description.

@ShahimSharafudeen
Copy link
Contributor Author

@tdcmeehan - Could you please merge this PR ?

@tdcmeehan tdcmeehan merged commit 7119aa2 into prestodb:master Feb 6, 2025
55 checks passed
@prestodb-ci prestodb-ci mentioned this pull request Mar 28, 2025
30 tasks
@prestodb-ci prestodb-ci requested review from a team, auden-woolfson and jp-sivaprasad and removed request for a team April 3, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants