Skip to content

Revert " Upgrade Okie to version 3.6.0 and OkHttp to version 4.12.0"#24459

Merged
arhimondr merged 1 commit intoprestodb:masterfrom
arhimondr:revert_okhttp
Jan 30, 2025
Merged

Revert " Upgrade Okie to version 3.6.0 and OkHttp to version 4.12.0"#24459
arhimondr merged 1 commit intoprestodb:masterfrom
arhimondr:revert_okhttp

Conversation

@arhimondr
Copy link
Member

This reverts commit 01bdab4.

  • Dependency conflicts ignored here causing issues downstream
  • Kotlin dependencies (kotlin.*) as well as Jetbrains annotations (org.intellij.*, org.jetbrains.*) must be properly shaded in presto-jdbc (and potentially other modules requiting shading, needs confirmation)
== NO RELEASE NOTE ==

@arhimondr arhimondr requested a review from a team as a code owner January 29, 2025 23:48
@arhimondr arhimondr requested a review from presto-oss January 29, 2025 23:48
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 29, 2025
Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arhimondr

@arhimondr arhimondr merged commit 08fe81c into prestodb:master Jan 30, 2025
54 checks passed
@arhimondr arhimondr deleted the revert_okhttp branch January 30, 2025 02:31
@ethanyzhang
Copy link
Contributor

@Mariamalmesfer can you look into this and reintroduce the fix?

@Mariamalmesfer
Copy link
Contributor

@Mariamalmesfer can you look into this and reintroduce the fix?

Sure, I'm on it! You can follow the progress on #24473 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants