Skip to content

Security Fix: Okio CVE-2023-3635 + OkHttp Jar Update#23796

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
Mariamalmesfer:okie-fix
Jan 28, 2025
Merged

Security Fix: Okio CVE-2023-3635 + OkHttp Jar Update#23796
tdcmeehan merged 1 commit intoprestodb:masterfrom
Mariamalmesfer:okie-fix

Conversation

@Mariamalmesfer
Copy link
Contributor

@Mariamalmesfer Mariamalmesfer commented Oct 9, 2024

Description

This PR fixes the Okio security vulnerability (CVE-2023-3635) by upgrading from version 1.17.2 to 3.6.0. It also includes an update to the OkHttp jar from 3.9.0 to 4.12.0

Motivation and Context

A flaw was found in Okio’s GzipSource class that doesn’t handle exceptions properly, allowing potential Denial of Service (DoS) attacks with malformed files.

CVE-2023-3635: Details

Impact

Image Scan showed the vulnerability have been removed.
correlation-report-ibm-lh-presto-okie check.csv

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

 == RELEASE NOTES == =
Security Changes
* Upgrade okio to 3.6.0 in response to `CVE-2023-3635 <https://github.com/advisories/GHSA-w33c-445m-f8w7>`_. :pr:`23796`
* Upgrade okhttp to 4.12.0 in response to `CVE-2023-3635 <https://github.com/advisories/GHSA-w33c-445m-f8w7>`_.  :pr:`23796`

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 9, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Mariamalmesfer / name: Mariam AlMesfer (4bbd3de)

@Mariamalmesfer Mariamalmesfer force-pushed the okie-fix branch 2 times, most recently from 1e17bcc to 8bed2f9 Compare October 13, 2024 09:24
@Mariamalmesfer Mariamalmesfer marked this pull request as ready for review October 13, 2024 09:34
@Mariamalmesfer Mariamalmesfer requested a review from a team as a code owner October 13, 2024 09:34
@ZacBlanco ZacBlanco self-requested a review October 14, 2024 17:14
@Mariamalmesfer Mariamalmesfer force-pushed the okie-fix branch 3 times, most recently from f8715a8 to e3b47f0 Compare October 15, 2024 13:51
@Mariamalmesfer Mariamalmesfer marked this pull request as draft October 24, 2024 08:04
@Mariamalmesfer Mariamalmesfer force-pushed the okie-fix branch 5 times, most recently from e13efb9 to dab801a Compare November 4, 2024 06:46
@steveburnett
Copy link
Contributor

Thanks for the release note entry! Nit to remove # from the PR number.

 == RELEASE NOTES == =

Security Changes
* Upgrade okio to 3.6.0 :pr:`23796`
* Upgrade okhttp to 4.12.0 :pr:`23796`

@Mariamalmesfer Mariamalmesfer force-pushed the okie-fix branch 12 times, most recently from af5b4c3 to ef04384 Compare November 7, 2024 22:14
@Mariamalmesfer Mariamalmesfer force-pushed the okie-fix branch 2 times, most recently from 85bca20 to f3d345d Compare January 21, 2025 09:53
aaneja
aaneja previously approved these changes Jan 22, 2025
@tdcmeehan tdcmeehan merged commit 01bdab4 into prestodb:master Jan 28, 2025
52 checks passed
<artifactId>okhttp</artifactId>
<exclusions>
<exclusion>
<groupId>org.jetbrains</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What issue does this dependency cause? Is this dependency needed in runtime?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exclusion prevents a build failure due to scope conflicts. Without it, Maven reports scope issues that lead to build failures. This dependency isn't needed at runtime; it's only required to pass the build checks.

@prestodb-ci
Copy link
Contributor

@ethanyzhang imported this issue into IBM GitHub Enterprise

@prestodb-ci prestodb-ci mentioned this pull request Mar 28, 2025
30 tasks
@prestodb-ci prestodb-ci requested review from a team and BryanCutler and removed request for a team and zuyu April 3, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants