Skip to content

[Iceberg] Fix argument order in bucket transforms #24309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZacBlanco merged 1 commit into from
Jan 1, 2025
Merged

[Iceberg] Fix argument order in bucket transforms #24309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions presto-iceberg/src/main/java/com/facebook/presto/iceberg/PartitionTransforms.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ private static Block bucketInteger(Block block, int count)

private static int bucketValueInteger(Block block, int position, int count)
{
return bucketValue(block, count, position, pos -> bucketHash(INTEGER.getLong(block, pos)));
return bucketValue(block, position, count, pos -> bucketHash(INTEGER.getLong(block, pos)));
}

private static Block bucketBigint(Block block, int count)
Expand All @@ -259,7 +259,7 @@ private static Block bucketBigint(Block block, int count)

private static int bucketValueBigint(Block block, int position, int count)
{
return bucketValue(block, count, position, pos -> bucketHash(BIGINT.getLong(block, pos)));
return bucketValue(block, position, count, pos -> bucketHash(BIGINT.getLong(block, pos)));
}

private static Block bucketShortDecimal(DecimalType decimal, Block block, int count)
Expand All @@ -273,7 +273,7 @@ private static Block bucketShortDecimal(DecimalType decimal, Block block, int co

private static int bucketValueShortDecimal(DecimalType decimal, Block block, int position, int count)
{
return bucketValue(block, count, position, pos -> {
return bucketValue(block, position, count, pos -> {
// TODO: write optimized implementation
BigDecimal value = readBigDecimal(decimal, block, pos);
return bucketHash(Slices.wrappedBuffer(value.unscaledValue().toByteArray()));
Expand All @@ -291,7 +291,7 @@ private static Block bucketLongDecimal(DecimalType decimal, Block block, int cou

private static int bucketValueLongDecimal(DecimalType decimal, Block block, int position, int count)
{
return bucketValue(block, count, position, pos -> {
return bucketValue(block, position, count, pos -> {
// TODO: write optimized implementation
BigDecimal value = readBigDecimal(decimal, block, pos);
return bucketHash(Slices.wrappedBuffer(value.unscaledValue().toByteArray()));
Expand Down