[Iceberg] Fix argument order in bucket transforms#24309
Merged
ZacBlanco merged 1 commit intoprestodb:masterfrom Jan 1, 2025
Merged
[Iceberg] Fix argument order in bucket transforms#24309ZacBlanco merged 1 commit intoprestodb:masterfrom
ZacBlanco merged 1 commit intoprestodb:masterfrom
Conversation
1c2f739 to
455c3bf
Compare
Position and count seemed to be swapped accidentally in some cases
455c3bf to
bfcca31
Compare
hantangwangd
approved these changes
Dec 31, 2024
6 tasks
Contributor
Author
|
@hantangwangd FYI after further analysis I don't believe it is actually possible to trigger this codepath because the error occurs only for the So we won't be able to write a test for this. It is more like a cosmetic change. |
Member
|
@ZacBlanco Thanks for the analysis. You are right that the constructed bucket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Swap arguments to their correct positions in the
bucketValuesfunction.Motivation and Context
Argument ordering is wrong and can cause incorrect data returned in queries on bucketed tables. This does not affect writing of the tables tables
Impact
IcebergPlanOptimizer. It's unlikely that any users encountered this as it seems the codepath required to hit this error is gated by a conditional which prevents us from utilizing the "valueTransform" with bucketed partitioning functions. code.Test Plan
Contributor checklist
Release Notes