Skip to content

Remove array_dupes and array_has_dupes alias. #23762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitkdutta merged 1 commit into from
Oct 2, 2024
Merged

Remove array_dupes and array_has_dupes alias. #23762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions presto-main/src/main/java/com/facebook/presto/operator/scalar/sql/ArraySqlFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public static String arrayFrequency()
"m -> m)";
}

@SqlInvokedScalarFunction(value = "array_duplicates", alias = {"array_dupes"}, deterministic = true, calledOnNullInput = false)
@SqlInvokedScalarFunction(value = "array_duplicates", deterministic = true, calledOnNullInput = false)
@Description("Returns set of elements that have duplicates")
@SqlParameter(name = "input", type = "array(T)")
@TypeParameter("T")
Expand All @@ -81,7 +81,7 @@ public static String arrayDuplicates()
"map_keys(map_filter(array_frequency(input), (k, v) -> v > 1)))";
}

@SqlInvokedScalarFunction(value = "array_has_duplicates", alias = {"array_has_dupes"}, deterministic = true, calledOnNullInput = false)
@SqlInvokedScalarFunction(value = "array_has_duplicates", deterministic = true, calledOnNullInput = false)
@Description("Returns whether array has any duplicate element")
@TypeParameter("T")
@SqlParameter(name = "input", type = "array(T)")
Expand Down
6 changes: 0 additions & 6 deletions presto-main/src/test/java/com/facebook/presto/operator/scalar/sql/TestArraySqlFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,6 @@ public void testArrayHasDuplicates()
assertFunction("array_has_duplicates(array[0, null])", BOOLEAN, false);
assertFunction("array_has_duplicates(array[0, null, null])", BOOLEAN, true);

// Test legacy name.
assertFunction("array_has_dupes(array[varchar 'a', varchar 'b', varchar 'a'])", BOOLEAN, true);

assertFunction("array_has_duplicates(array[array[1], array[2], array[]])", BOOLEAN, false);
assertFunction("array_has_duplicates(array[array[1], array[2], array[2]])", BOOLEAN, true);
assertFunction("array_has_duplicates(array[(1, 2), (1, 2)])", BOOLEAN, true);
Expand All @@ -224,9 +221,6 @@ public void testArrayDuplicates()
assertFunction("array_duplicates(array[0, null])", new ArrayType(INTEGER), ImmutableList.of());
assertFunction("array_duplicates(array[0, null, null])", new ArrayType(INTEGER), singletonList(null));

// Test legacy name.
assertFunction("array_dupes(array[1, 2, 1])", new ArrayType(INTEGER), ImmutableList.of(1));

RowType rowType = RowType.from(ImmutableList.of(RowType.field(INTEGER), RowType.field(INTEGER)));
assertFunction("array_duplicates(array[array[1], array[2], array[]])", new ArrayType(new ArrayType(INTEGER)), ImmutableList.of());
assertFunction("array_duplicates(array[array[1], array[2], array[2]])", new ArrayType(new ArrayType(INTEGER)), ImmutableList.of(ImmutableList.of(2)));
Expand Down