Skip to content

Include relevant retry info in hbo rst#23335

Merged
abhinavmuk04 merged 1 commit intoprestodb:masterfrom
abhinavmuk04:addretrytohborst
Aug 1, 2024
Merged

Include relevant retry info in hbo rst#23335
abhinavmuk04 merged 1 commit intoprestodb:masterfrom
abhinavmuk04:addretrytohborst

Conversation

@abhinavmuk04
Copy link
Contributor

Description

Include relevant retry info in hbo rst

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@github-actions github-actions bot added the docs label Jul 30, 2024
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration properties table is malformed, so that table does not appear in a local docs build.

Screenshot of local docs build
Screenshot 2024-07-31 at 10 10 32 AM

I noticed this earlier this week and opened PR #23322 to fix it, look at that PR for the errors and the fix in context.

GitHub won't let me comment on the specific line in this PR, but add == to the first line of == in line 34 and that should fix the problem. When I edited line 34 locally and did a new local build, the config properties table was displayed, and your new additions to that table and the session properties table look okay.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the table display is fixed! Two nits about punctuation in the config property name.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, everything looks good. Thanks!

@abhinavmuk04 abhinavmuk04 marked this pull request as ready for review August 1, 2024 16:59
@abhinavmuk04 abhinavmuk04 requested review from a team and elharo as code owners August 1, 2024 16:59
@abhinavmuk04 abhinavmuk04 requested a review from presto-oss August 1, 2024 16:59
@abhinavmuk04 abhinavmuk04 merged commit 1e5d099 into prestodb:master Aug 1, 2024
@abhinavmuk04 abhinavmuk04 deleted the addretrytohborst branch August 1, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants