Skip to content

[docs] Fix table formatting in history-based-optimization.rst#23322

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
steveburnett:steveburnett-fix-hbo-doc-error
Aug 2, 2024
Merged

[docs] Fix table formatting in history-based-optimization.rst#23322
tdcmeehan merged 1 commit intoprestodb:masterfrom
steveburnett:steveburnett-fix-hbo-doc-error

Conversation

@steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Jul 29, 2024

Description

New error in local doc build:

/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/optimizer/history-based-optimization.rst:34: ERROR: Malformed table. Column span alignment problem in table line 3.

and

build succeeded, 20 warnings.

Motivation and Context

Fixes one error in the doc build because the table is incorrectly formatted.

Impact

Documentation.

Test Plan

Local doc builds.

Before fix:

/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/optimizer/history-based-optimization.rst:34: ERROR: Malformed table. Column span alignment problem in table line 3.

and

build succeeded, 20 warnings.

After fix:

ERROR: Malformed table. does not appear.

build succeeded, 19 warnings.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@steveburnett steveburnett self-assigned this Jul 29, 2024
@steveburnett steveburnett requested review from a team and elharo as code owners July 29, 2024 18:14
@steveburnett steveburnett requested a review from presto-oss July 29, 2024 18:14
@github-actions github-actions bot added the docs label Jul 29, 2024
@steveburnett
Copy link
Contributor Author

This has also been fixed in #23335.

@tdcmeehan tdcmeehan merged commit 27a3384 into prestodb:master Aug 2, 2024
@steveburnett steveburnett deleted the steveburnett-fix-hbo-doc-error branch August 5, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants