Skip to content

[native] Include additional context from velox exception#23025

Merged
aditi-pandit merged 1 commit intoprestodb:masterfrom
bikramSingh91:VeloxExceptionParsing
Jun 17, 2024
Merged

[native] Include additional context from velox exception#23025
aditi-pandit merged 1 commit intoprestodb:masterfrom
bikramSingh91:VeloxExceptionParsing

Conversation

@bikramSingh91
Copy link
Contributor

Ensure inclusion of "additional context" from Velox exceptions in
the translation to Presto's ExecutionFailureInfo (which is used
for propagating the query failure error to the coordinator). See
Velox PR (facebookincubator/velox#9695)
for more details on "additional context"

Test Plan:
Enhanced existing unit test.

Ensure inclusion of "additional context" from Velox exceptions in
the translation to Presto's ExecutionFailureInfo (which is used
for propagating the query failure error to the coordinator). See
Velox PR (facebookincubator/velox#9695)
for more details on "additional context"

Test Plan:
Enhanced existing unit test.
@bikramSingh91 bikramSingh91 requested a review from a team as a code owner June 17, 2024 21:17
Copy link
Contributor

@spershin spershin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks!

Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditi-pandit aditi-pandit merged commit 1286ae4 into prestodb:master Jun 17, 2024
@tdcmeehan tdcmeehan mentioned this pull request Aug 23, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants