Enhance hierarchical addition on exception context#9695
Closed
bikramSingh91 wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Enhance hierarchical addition on exception context#9695bikramSingh91 wants to merge 1 commit intofacebookincubator:mainfrom
bikramSingh91 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56913321 |
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
reviewed
May 3, 2024
mbasmanova
approved these changes
May 3, 2024
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
@bikramSingh91 Thank you. This should make it a bit easier to debug query failures.
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 3, 2024
…#9695) Summary: Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321
bikramSingh91
force-pushed
the
export-D56913321
branch
from
926b8c2 to
3720027
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56913321 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 3, 2024
…#9695) Summary: Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321
bikramSingh91
force-pushed
the
export-D56913321
branch
from
3720027 to
0285f62
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56913321 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 3, 2024
…#9695) Summary: Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321
bikramSingh91
force-pushed
the
export-D56913321
branch
from
0285f62 to
6b0946c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56913321 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 3, 2024
…#9695) Summary: Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321
bikramSingh91
force-pushed
the
export-D56913321
branch
from
6b0946c to
a6ba90a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56913321 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 3, 2024
…#9695) Summary: Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321
bikramSingh91
force-pushed
the
export-D56913321
branch
from
a6ba90a to
82b6078
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56913321 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 3, 2024
…#9695) Summary: Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321
bikramSingh91
force-pushed
the
export-D56913321
branch
from
82b6078 to
d19a50b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56913321 |
…#9695) Summary: Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 6, 2024
…#9695) Summary: Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321
bikramSingh91
force-pushed
the
export-D56913321
branch
from
d19a50b to
cf44dfb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56913321 |
bikramSingh91
force-pushed
the
export-D56913321
branch
from
cf44dfb to
f2f8986
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56913321 |
Contributor
|
This pull request has been merged in 5bf1e27. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
May 8, 2024
…#9695) Summary: Pull Request resolved: facebookincubator#9695 Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321 fbshipit-source-id: abc56abb72b0e526d8858232031279ad7a72a238
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…#9695) Summary: Pull Request resolved: facebookincubator#9695 Currently, VeloxExceptions have the ability to add additional context from the top most level Exception context. This is useful for debugging exceptions thrown during expression evaluation where we want to know the current expression that threw it and the top level one that contains it. With this change, the "Top-level Context" concept is replaced by "Additional Context", and a new field called "isEssential" is added to the ExceptionContext to specify whether the context should always be part of the exception when traversing the hierarchy. This modification enables adding context at various levels within the hierarchy. Moreover, using this new method, extra details about the operator and relevant metadata are now included in the exception to facilitate debugging when queries fail due to runtime exceptions. Reviewed By: mbasmanova Differential Revision: D56913321 fbshipit-source-id: abc56abb72b0e526d8858232031279ad7a72a238
bikramSingh91
added a commit
to bikramSingh91/presto
that referenced
this pull request
Jun 17, 2024
Ensure inclusion of "additional context" from Velox exceptions in the translation to Presto's ExecutionFailureInfo (which is used for propagating the query failure error to the coordinator). See Velox PR (facebookincubator/velox#9695) for more details on "additional context" Test Plan: Enhanced existing unit test.
aditi-pandit
pushed a commit
to prestodb/presto
that referenced
this pull request
Jun 17, 2024
Ensure inclusion of "additional context" from Velox exceptions in the translation to Presto's ExecutionFailureInfo (which is used for propagating the query failure error to the coordinator). See Velox PR (facebookincubator/velox#9695) for more details on "additional context" Test Plan: Enhanced existing unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, VeloxExceptions have the ability to add additional context
from the top most level Exception context. This is useful for
debugging exceptions thrown during expression evaluation where we
want to know the current expression that threw it and the top level
one that contains it.
With this change, the "Top-level Context" concept is replaced by
"Additional Context", and a new field called "isEssential" is added
to the ExceptionContext to specify whether the context should always
be part of the exception when traversing the hierarchy. This
modification enables adding context at various levels within the
hierarchy.
Moreover, using this new method, extra details about the operator
and relevant metadata are now included in the exception to
facilitate debugging when queries fail due to runtime exceptions.
As an example, the exception thrown while executing an operator
will look like this:
Differential Revision: D56913321