Skip to content

[native] Register Velox hive connector factory for iceberg #22710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aditi-pandit merged 1 commit into from
May 10, 2024
Merged

[native] Register Velox hive connector factory for iceberg #22710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions presto-native-execution/etc/catalog/iceberg.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
# The Presto "iceberg" catalog is handled by the hive connector in Presto native execution.
connector.name=hive
connector.name=iceberg
6 changes: 6 additions & 0 deletions presto-native-execution/presto_cpp/main/PrestoServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
#include "velox/common/memory/MmapAllocator.h"
#include "velox/common/memory/SharedArbitrator.h"
#include "velox/connectors/Connector.h"
#include "velox/connectors/hive/HiveConnector.h"
#include "velox/core/Config.h"
#include "velox/exec/OutputBufferManager.h"
#include "velox/functions/prestosql/aggregates/RegisterAggregateFunctions.h"
Expand Down Expand Up @@ -225,6 +226,11 @@ void PrestoServer::run() {
registerShuffleInterfaceFactories();
registerCustomOperators();

// Register Velox connector factory for iceberg.
// The iceberg catalog is handled by the hive connector factory.
connector::registerConnectorFactory(
std::make_shared<connector::hive::HiveConnectorFactory>("iceberg"));

registerPrestoToVeloxConnector(
std::make_unique<HivePrestoToVeloxConnector>("hive"));
registerPrestoToVeloxConnector(
Expand Down