[native] Register Velox hive connector factory for iceberg#22710
Merged
aditi-pandit merged 1 commit intoprestodb:masterfrom May 10, 2024
Merged
[native] Register Velox hive connector factory for iceberg#22710aditi-pandit merged 1 commit intoprestodb:masterfrom
aditi-pandit merged 1 commit intoprestodb:masterfrom
Conversation
majetideepak
requested review from
agrawalreetika,
czentgr,
imjalpreet and
yingsu00
The current iceberg catalog uses "hive" for the connector.name. Register a Velox hive connector factory for iceberg with name `iceberg`. "connector.name=iceberg" is now supported.
aditi-pandit
reviewed
May 9, 2024
Contributor
aditi-pandit
left a comment
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @majetideepak. Minor nit.
imjalpreet
approved these changes
May 10, 2024
Member
imjalpreet
left a comment
imjalpreet
left a comment
There was a problem hiding this comment.
LGTM, thanks @majetideepak
Collaborator
Author
|
@aditi-pandit can you approve if you have no other comments? Thanks. |
czentgr
approved these changes
May 10, 2024
aditi-pandit
approved these changes
May 10, 2024
Contributor
aditi-pandit
left a comment
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @majetideepak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current iceberg catalog uses hive for the
connector.name.Register a Velox hive connector factory for iceberg with name
iceberg.connector.name=icebergis now supported.Motivation and Context
Impact
Test Plan
Contributor checklist