Revert "Add histograms for optimizer cost calculation"#22661
Merged
feilong-liu merged 4 commits intoprestodb:masterfrom May 3, 2024
Merged
Revert "Add histograms for optimizer cost calculation"#22661feilong-liu merged 4 commits intoprestodb:masterfrom
feilong-liu merged 4 commits intoprestodb:masterfrom
Conversation
This reverts commit e8c4659.
6 tasks
kaikalur
previously approved these changes
May 3, 2024
This reverts commit 457d812.
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 2381d19...a07d5a4.
|
…bled" This reverts commit b2d4532.
Contributor
|
Thanks for identifying this. I found the root cause. I'll see to fixing it while this is reverted. |
rschlussel
previously approved these changes
May 3, 2024
Contributor
rschlussel
left a comment
There was a problem hiding this comment.
thanks for giving a detailed explanation of the reason for reverting!
hantangwangd
previously approved these changes
May 3, 2024
Fix this test as part of revert PR prestodb#22661 I chose to fix forward because the original PR is mainy for flaky test fix and has light dependency on the reverted PR hence fix forward is a better option.
rschlussel
approved these changes
May 3, 2024
ZacBlanco
approved these changes
May 3, 2024
steveburnett
approved these changes
May 3, 2024
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local build of docs, looks good.
6 tasks
tanjialiang
approved these changes
May 3, 2024
6 tasks
zacw7
pushed a commit
that referenced
this pull request
May 7, 2024
Fix this test as part of revert PR #22661 I chose to fix forward because the original PR is mainy for flaky test fix and has light dependency on the reverted PR hence fix forward is a better option.
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e8c4659. This reverts PR #21236
As there are other PRs referring to the changes in this PR, hence also reverting #22327 and #22395 here
Description
This reverted commit will make query with large IN clause to be super slow. In the test query I ran, the latency increase from 7 seconds to 4 and half minutes!
If not reverting, it will take 4 and half minutes to execute this query.
After revert the change, it will take only 7 seconds!
Motivation and Context
The above is a synthetic query I created to demonstrate the problem.
We already observe queries in our production seeing longer latency and even fail/timeout.
Impact
Fix latency regression and query timeout failure
Test Plan
Existing unit tests, and also tested locally end to end with production queries.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.