[Iceberg] Add predicate in layout without pushdown_filter_enabled#22395
Merged
ZacBlanco merged 1 commit intoprestodb:masterfrom May 1, 2024
Merged
Conversation
ZacBlanco
force-pushed
the
upstream-iceberg-stat-select-inconsistency
branch
10 times, most recently
from
f5d4180 to
407a56a
Compare
ZacBlanco
changed the title
hantangwangd
previously approved these changes
Apr 6, 2024
presto-spi/src/main/java/com/facebook/presto/spi/statistics/ColumnStatistics.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergAbstractMetadata.java
Show resolved
Hide resolved
ZacBlanco
force-pushed
the
upstream-iceberg-stat-select-inconsistency
branch
from
407a56a to
5bf3f7c
Compare
hantangwangd
previously approved these changes
Apr 8, 2024
ZacBlanco
force-pushed
the
upstream-iceberg-stat-select-inconsistency
branch
from
5bf3f7c to
ca1c9f5
Compare
The `iceberg.pushdown_filter_enabled` flag added recently changed how the iceberg connector metadata generates table layouts. The previous fork in the logic would cause layouts to be generated without a partition predicate constraint even if it existed. This can lead to table stats being incorrect and hence incorrect statistics and poor query planning when filtering on partitioned tables or when the config is disabled. The original logic led to the codepath which was responsible for filling in the predicate for tables when filter pushdown was disabled to be unreachable. This change will now allows the predicates to show up on partition columns in the layout.
ZacBlanco
force-pushed
the
upstream-iceberg-stat-select-inconsistency
branch
from
ca1c9f5 to
4053a18
Compare
tdcmeehan
approved these changes
Apr 30, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
iceberg.pushdown_filter_enabledflag added recentlychanged how the iceberg connector metadata generates
table layouts. The previous fork in the logic would cause
layouts to be generated without a partition predicate constraint
even if it existed. This can lead to table stats being incorrect
and hence incorrect statistics and poor query planning when
filtering on partitioned tables or when the config is disabled.
The original logic led to the codepath responsible for
filling in the predicate for tables when filter pushdown was disabled
to be unreachable. This change will now allows the predicates to
show up on partition columns in the layout.
Motivation and Context
Incorrect stats for planning.
Fixes #22357
Impact
N/A
Test Plan
Contributor checklist
Release Notes