[native] Add support for optional velox.properties file#21962
Merged
majetideepak merged 1 commit intoprestodb:masterfrom Feb 20, 2024
Merged
[native] Add support for optional velox.properties file#21962majetideepak merged 1 commit intoprestodb:masterfrom
majetideepak merged 1 commit intoprestodb:masterfrom
Conversation
6 tasks
f31e6e5 to
28ee9b7
Compare
28ee9b7 to
a67d5f4
Compare
amitkdutta
approved these changes
Feb 20, 2024
Contributor
amitkdutta
left a comment
There was a problem hiding this comment.
Looks good. Thanks @majetideepak
We had a discussion in #20406
My personal opinion is we stick with config properties and remove velox properties file - one less config to manage and eases deployment.
Collaborator
Author
@amitkdutta Let's bring this up in the next Prestissimo WG meeting. CC: @aditi-pandit |
Contributor
CC: @spershin |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Velox config has no required fields and therefore velox.properties should be optional.
From a Presto user perspective, existing config files (config.properties, node.properties)
for Java should work for Prestissimo as well.
Motivation and Context
Make Prestissimo config aligned to Presto Java
Impact
velox.properties is now optional.
Test Plan
Tested locally.
Contributor checklist