[native] Add dockerfiles for dependencies and runtime and remove existing dockerfiles by majetideepak · Pull Request #21929 · prestodb/presto

majetideepak · 2024-02-14T06:00:21Z

Description

Remove the existing dockerfiles for Prestissimo as they are out of date.
We split the release-centos-dockerfile into dependency image dockerfile
and runtime image dockerfile.
This split is helpful since the dependencies are rarely updated. Prestissimo can
now build faster from the dependency image.
The orchestration will be moved to the helm project.
The release team will also use the new dockerfiles to release official dependency
and runtime Prestissimo images.

Motivation and Context

There are no working dockerfiles for Prestissimo. This PR adds these files.

Impact

Enable official Prestissimo dependency and runtime images.

Test Plan

Approval from the release team.

Contributor checklist

Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Prestissimo (Native Execution)
* Add dockerfiles for dependencies and runtime

mbasmanova

@majetideepak This is nice.

mbasmanova · 2024-02-14T07:07:43Z

presto-native-execution/scripts/dockerfiles/README.md

typo: "This images needs" -> "... image ..."

mbasmanova · 2024-02-14T07:07:55Z

presto-native-execution/scripts/dockerfiles/README.md

nit: drop "very"

mbasmanova · 2024-02-14T07:11:20Z

presto-native-execution/Makefile

Would you update presto-native-execution/README.md since it has references to these deleted targets?

Good point! done!

mbasmanova · 2024-02-14T07:12:07Z

presto-native-execution/scripts/release-centos-dockerfile/etc/config.properties.template

Wondering why we don't need something like this anymore.

The configs and deployment are part of the orchestration layer. These will be added on top of the native runtime image. These configs are dynamic and cannot be hard-coded.
We have a helm project that could add these templates.
I will ask the release team to publish another image with the Java package (coordinator) added to the native runtime image along with these configs so that users can evaluate Prestissimo.

wanglinsong · 2024-02-14T19:44:53Z

Is it possible to have a default velox.properties built into the image?

kgpai · 2024-02-14T19:57:44Z

presto-native-execution/Makefile

+# Possible values are centos, ubuntu
+OSNAME ?= centos
+ARCH ?= $(shell uname -p)
+DEPENDENCY_IMAGE_NAME ?= prestissimo/dependency-$(ARCH)-$(OSNAME)


Velox has a docker-compose.yml that allows us to have multiple images with their base image names etc. That way you can just have on command to build the dependency image and runtime image.

I believe docker-compose is not being used on the Java packaging side. But I like the docker-compose API.
@wanglinsong Any thoughts on this?
https://github.com/facebookincubator/velox/blob/main/docker-compose.yml

There's some examples for both Prestissimo and Presto Java in the Prestorials repo: https://github.com/prestodb/prestorials

Let's use docker compose instead of Makefile targets. I will fix this.

kgpai · 2024-02-14T19:59:22Z

presto-native-execution/README.md

-Run `make runtime-container` in the presto-native-execution root directory
-to build run-ready containerized version of Prestissimo. Information on available
-configuration options can be found in [scripts/release-centos-dockerfile/README.md](scripts/release-centos-dockerfile/README.md)
+Run `make dependency-image && make runtime-image` in the presto-native-execution root directory


nit: maybe have a target called make images that is dependent on both ?

I wanted to do this but decided not to since Docker was rebuilding the runtime-image every time even without any changes. Likely because of some timestamp changes when it invokes make dependency-image.

kgpai · 2024-02-14T20:09:05Z

presto-native-execution/scripts/dockerfiles/dependency.dockerfile

+RUN mkdir build && (cd build && \
+    if [ "${OSNAME}" = "centos" ] ; then \
+        ../velox/scripts/setup-centos8.sh ; \
+        export CC=/opt/rh/gcc-toolset-9/root/bin/gcc ; \


Can we move the export env variables to just use ENV above ; I think these are not limited to just centos .

These are limited to rhel(centos).

kgpai · 2024-02-14T20:09:38Z

presto-native-execution/scripts/dockerfiles/prestissimo.dockerfile

+        export CXX=/opt/rh/gcc-toolset-9/root/bin/g++ ; \
+    fi && EXTRA_CMAKE_FLAGS=${EXTRA_CMAKE_FLAGS} \
+    make -j$(nproc) --directory="/prestissimo/" cmake-and-build BUILD_TYPE=${BUILD_TYPE} BUILD_DIR=${BUILD_DIR} BUILD_BASE_DIR=${BUILD_BASE_DIR}
+RUN ldd /prestissimo/${BUILD_BASE_DIR}/${BUILD_DIR}/presto_cpp/main/presto_server | awk 'NF == 4 { system("cp " $3 " /runtime-libraries") }'


What is this for ?

This command copies the shared (dynamic) libraries required by the presto_server.

majetideepak · 2024-02-15T04:57:23Z

Is it possible to have a default velox.properties built into the image?

@wanglinsong Any reason for this particular file? Should we put other default .properties files as well? I feel we should have another images with the Java package added to the runtime image along with the configs so that users can try out Prestissimo.

wanglinsong · 2024-02-16T08:08:07Z

Is it possible to have a default velox.properties built into the image?

@wanglinsong Any reason for this particular file? Should we put other default .properties files as well? I feel we should have another images with the Java package added to the runtime image along with the configs so that users can try out Prestissimo.

velox.properties file is only needed by native workers to work. This is the one we use now - https://github.com/prestodb/presto/blob/native-worker-image/presto-native-execution/velox.properties.
This file is copied into final native docker image, see https://github.com/prestodb/presto/blob/native-worker-image/Dockerfile-native#L19

majetideepak · 2024-02-19T14:45:16Z

This is the one we use now

@wanglinsong velox.properties should be optional and limited to advanced users.
I opened a PR to support that here #21962
The velox.properties file you shared has the following properties and it is not clear
why they are not the default and why users must explicitly specify them.

mutable-config=true
expression.eval_simplified=false
max_split_preload_per_driver=0

This script is out of date and is broken. We should seperate this work into dependency image, runtime image, and orchestration.

This script is out of date. It uses a Velox circle ci image as the base image. Presto release team should build and manage the base image.

steveburnett

Nice work, thanks! A few nits and a small formatting suggestion, looks good.

presto-native-execution/scripts/dockerfiles/README.md

majetideepak · 2024-05-13T22:42:29Z

@steveburnett thanks for the corrections!

steveburnett

LGTM! (docs)

I focused on presto-native-execution/scripts/dockerfiles/README.md.
All my requested changes from my review yesterday are incorporated now.
I reviewed the full document and find nothing else to comment about today. Thanks!

czentgr

Looks good! I have only one question.

czentgr · 2024-05-14T15:22:36Z

presto-native-execution/scripts/dockerfiles/prestissimo-runtime.dockerfile

+ENV BUILD_BASE_DIR=_build
+ENV BUILD_DIR=""
+
+COPY --chown=186:root --chmod=0775 --from=prestissimo-image /prestissimo/${BUILD_BASE_DIR}/${BUILD_DIR}/presto_cpp/main/presto_server /usr/local/bin/


Why was chown necessary here to user id 186 of the build result? Do we need a comment to explain this?

Good catch! We don't need chown here. I removed it.

These dockerfiles allow building container images for dependencies and Prestissimo runtime.

majetideepak requested a review from wanglinsong February 14, 2024 06:01

majetideepak force-pushed the add-dev-dockerfiles branch from c36a5d1 to 697ecc0 Compare February 14, 2024 06:03

majetideepak marked this pull request as ready for review February 14, 2024 06:29

majetideepak requested a review from a team as a code owner February 14, 2024 06:29

mbasmanova reviewed Feb 14, 2024

View reviewed changes

majetideepak force-pushed the add-dev-dockerfiles branch 2 times, most recently from 8b2a749 to 92f7f56 Compare February 14, 2024 12:24

kgpai reviewed Feb 14, 2024

View reviewed changes

This was referenced Apr 19, 2024

[native] Update native worker docker image creation for CI #19211

Open

[native ] Fix setup scripts to align with Velox setup scripts #22448

Merged

majetideepak added 2 commits May 11, 2024 16:03

[native] Remove release-centos-dockerfile

e814bcc

This script is out of date and is broken. We should seperate this work into dependency image, runtime image, and orchestration.

[native] Remove centos-container.dockfile

e572b03

This script is out of date. It uses a Velox circle ci image as the base image. Presto release team should build and manage the base image.

majetideepak force-pushed the add-dev-dockerfiles branch from 92f7f56 to 3d42000 Compare May 13, 2024 13:30

majetideepak requested review from a team and steveburnett as code owners May 13, 2024 13:30

majetideepak requested a review from presto-oss May 13, 2024 13:30

steveburnett requested changes May 13, 2024

View reviewed changes

majetideepak force-pushed the add-dev-dockerfiles branch from 3d42000 to d9f9c86 Compare May 13, 2024 22:41

majetideepak force-pushed the add-dev-dockerfiles branch from d9f9c86 to bb3eadd Compare May 13, 2024 22:52

majetideepak requested review from czentgr May 14, 2024 02:00

steveburnett previously approved these changes May 14, 2024

View reviewed changes

czentgr reviewed May 14, 2024

View reviewed changes

majetideepak dismissed steveburnett’s stale review via 4e2cb0c May 14, 2024 23:05

majetideepak force-pushed the add-dev-dockerfiles branch from bb3eadd to 4e2cb0c Compare May 14, 2024 23:05

[native] Add dockerfiles for dependencies and runtime

cfff317

These dockerfiles allow building container images for dependencies and Prestissimo runtime.

majetideepak force-pushed the add-dev-dockerfiles branch from 4e2cb0c to cfff317 Compare May 15, 2024 01:20

tdcmeehan approved these changes May 15, 2024

View reviewed changes

majetideepak changed the title ~~[native] Add dockerfiles for dependencies and runtime~~ [native] Add dockerfiles for dependencies and runtime and remove existing dockerfiles May 15, 2024

tdcmeehan merged commit b64c64c into prestodb:master May 15, 2024

majetideepak deleted the add-dev-dockerfiles branch May 15, 2024 20:11

wanglinsong mentioned this pull request Jun 25, 2024

Add release notes for 0.288 #23079

Merged

36 tasks

Conversation

majetideepak commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

Uh oh!

mbasmanova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

majetideepak Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wanglinsong commented Feb 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

majetideepak Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

majetideepak commented Feb 15, 2024

Uh oh!

wanglinsong commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majetideepak commented Feb 19, 2024

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

majetideepak commented May 13, 2024

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

czentgr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

majetideepak commented Feb 14, 2024 •

edited

Loading

majetideepak Feb 14, 2024 •

edited

Loading

majetideepak Feb 15, 2024 •

edited

Loading

wanglinsong commented Feb 16, 2024 •

edited

Loading