[native] Disable partial aggregation over system table scan#21725
Merged
arhimondr merged 2 commits intoprestodb:masterfrom Jan 19, 2024
Merged
[native] Disable partial aggregation over system table scan#21725arhimondr merged 2 commits intoprestodb:masterfrom
arhimondr merged 2 commits intoprestodb:masterfrom
Conversation
arhimondr
requested review from
mbasmanova,
mlyublena and
presto-oss
and removed request for
presto-oss
arhimondr
force-pushed
the
native-system-connector-pushdown
branch
from
2bb3f18 to
f86ae2b
Compare
arhimondr
changed the title
mbasmanova
approved these changes
Jan 18, 2024
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
Thank you for a quick fix.
...va/com/facebook/presto/sql/planner/iterative/rule/PushPartialAggregationThroughExchange.java
Outdated
Show resolved
Hide resolved
arhimondr
force-pushed
the
native-system-connector-pushdown
branch
3 times, most recently
from
a0bdac3 to
6d37688
Compare
mlyublena
approved these changes
Jan 18, 2024
Follow up of prestodb#21285 Partial aggregation output might not be compatible between Java and C++ implementations
arhimondr
force-pushed
the
native-system-connector-pushdown
branch
from
6d37688 to
bf5b3f5
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid pushing down aggregations to a coordinator scheduled fragment (system table scan) that runs in Java.
Partial aggregation output is not binary compatible between Presto Java and Prestissimo.
Motivation and Context
In #21285 an extra exchange was introduced to minimize the scope of operations run on coordinator. However past
AddExchangespartial aggregation can be pushed down.Test Plan
Integration tests provided
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.