[native] Support system tables#21285
Merged
amitkdutta merged 3 commits intoprestodb:masterfrom Oct 31, 2023
Merged
Conversation
Member
Author
|
The idea is to insert an extra "GATHER" exchange right on top of a TableScan of a system table. This will ensure partitioning function is applied by native worker consistently. |
mbasmanova
approved these changes
Oct 31, 2023
Contributor
mbasmanova
left a comment
There was a problem hiding this comment.
@arhimondr Thank you, Andrii, for enabling queries that use system tables on Prestissimo and Presto-on-Spark on Velox.
Member
Author
|
@mbasmanova Happy to help Presto on Spark (even with Java execution) is not supported though for a different reason. In Presto on Spark a distributed stage cannot read from a coordinator stage. Queries that require a system table to be read by a distributed stage (such as join) are not supported. |
6 tasks
arhimondr
added a commit
to arhimondr/presto
that referenced
this pull request
Jan 19, 2024
Follow up of prestodb#21285 Partial aggregation output might not be compatible between Java and C++ implementations
arhimondr
added a commit
that referenced
this pull request
Jan 19, 2024
Follow up of #21285 Partial aggregation output might not be compatible between Java and C++ implementations
kaikalur
pushed a commit
to kaikalur/presto
that referenced
this pull request
Mar 14, 2024
Follow up of prestodb#21285 Partial aggregation output might not be compatible between Java and C++ implementations
wypb
pushed a commit
to wypb/presto
that referenced
this pull request
Apr 25, 2024
Follow up of prestodb#21285 Partial aggregation output might not be compatible between Java and C++ implementations
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Querying system tables with native execution enabled may result in incorrect result.
Motivation and Context
Native and Java based executions have different partitioning functions implementation hence queries such the one below may return incorrect result.
Impact
Incorrect results returned when querying system tables with native execution enabled
Test Plan
Integration test
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: