Add alias any_value for arbitrary#21389
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Nov 16, 2023
Merged
Conversation
|
|
shenh062326
force-pushed
the
any_value
branch
from
7601d75 to
d3cb356
Compare
Contributor
|
Consider adding documentation for this. Perhaps a good location would be immediately following the entry for arbitrary(x) in Aggregate Functions. |
shenh062326
force-pushed
the
any_value
branch
from
d3cb356 to
1fffb36
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 27c6d9e...5838d71.
|
Member
|
Can you add a small unit test around this? Seems trivial |
shenh062326
force-pushed
the
any_value
branch
from
1fffb36 to
1b1ee1c
Compare
Contributor
Author
Thanks for you comment, add documentation. |
Contributor
Author
Thanks for you comment, add TestAnyValueAggregation. |
shenh062326
force-pushed
the
any_value
branch
from
1b1ee1c to
5838d71
Compare
steveburnett
approved these changes
Nov 16, 2023
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Thank you for adding the documentation!
tdcmeehan
approved these changes
Nov 16, 2023
amitkdutta
pushed a commit
to amitkdutta/velox
that referenced
this pull request
Nov 22, 2023
Summary: Presto added `any_value` alias for arbitrary aggregate in prestodb/presto#21389 Differential Revision: D51521293
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Nov 22, 2023
Summary: Pull Request resolved: #7689 Presto added `any_value` alias for arbitrary aggregate in prestodb/presto#21389 Reviewed By: mbasmanova Differential Revision: D51521293 fbshipit-source-id: 64c219bc4ba18df65d2e77210405fa23e704d951
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is any_value in mysql, which returns any value in a group. It has the same semantics as presto's arbitrary, so we hope to add an alias any_value to arbitrary.
Motivation and Context
Some users are accustomed to the syntax of MySQL. When using presto, they find that the any_value function does not exist and can only be replaced by arbitrary. If any_value exists, it will be more friendly to users who are accustomed to the MySQL syntax.
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.