Add any_value alias for arbitrary aggregate.#7689
Add any_value alias for arbitrary aggregate.#7689amitkdutta wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51521293 |
There was a problem hiding this comment.
This name is used for error message. I passed the first name, also open to pass a concatenated string like "arbitrary/any_value".
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
@amitkdutta Thanks. Would you update documentation?
There was a problem hiding this comment.
return value doesn't seem to be used; maybe change to void
There was a problem hiding this comment.
@mbasmanova @kagamiori I think we can make all the register functions to return void. The return type is not used. In a separate change. Let me know what you think.
Summary: Presto added `any_value` alias for arbitrary aggregate in prestodb/presto#21389 Differential Revision: D51521293
amitkdutta
force-pushed
the
export-D51521293
branch
from
11d3087 to
106fb45
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51521293 |
|
This pull request has been merged in c1824e6. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…or#7864) Summary: Aggregate function registration does not utilize return type. Some registrations are done with void and some are done with return type - where return type is unused. Making all of them void, similar to what is done in facebookincubator#7689 Reviewed By: mbasmanova Differential Revision: D51593723
Summary: Pull Request resolved: #7864 Aggregate function registration does not utilize return type. Some registrations are done with void and some are done with return type - where return type is unused. Making all of them void, similar to what is done in #7689 Reviewed By: mbasmanova Differential Revision: D51593723 fbshipit-source-id: 088e25e9c8547cd4bf6260621ced4e07d5dfb7aa
3 participants
Summary:
Presto added
any_valuealias for arbitrary aggregate inprestodb/presto#21389
Differential Revision: D51521293