[native] Resolve antlr dependency for CTest on Apple Silicon#21374
Closed
czentgr wants to merge 1 commit intoprestodb:masterfrom
Closed
[native] Resolve antlr dependency for CTest on Apple Silicon#21374czentgr wants to merge 1 commit intoprestodb:masterfrom
czentgr wants to merge 1 commit intoprestodb:masterfrom
Conversation
7550041 to
c07fadd
Compare
On Apple M1 antlr is installed to /usr/local/lib. When running Ctest (e.g. make unittest) some tests fail due to antlr library not being found. Executing the tests manually on a terminal works as expected. The issue is only in Ctest. Setting the DYLD_LIBRARY_PATH explicitly in the environment does not resolve the issue and the CMakeLists.txt for each affected test needs to be modified.
c07fadd to
17fc495
Compare
Collaborator
Contributor
Author
|
@majetideepak Thanks! Not sure why this suddenly became a problem on the Silicon Apple Macs. Anyway, lets keep this PR as a workaround for anyone looking and close it once your PR got merged. |
Collaborator
Contributor
|
@czentgr shall we close this then? |
Contributor
Author
|
@yzhang1991 Yup, thanks. I Was investigating an issue running the tests from the makefile which was identified by Deepak (including a solution) today as well. But I confirmed that this PR can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Apple M1 antlr is installed to /usr/local/lib. When running Ctest (e.g. make unittest) some tests fail due to antlr library not being found. Executing the tests manually on a terminal works as expected. The issue is only in Ctest. Setting the DYLD_LIBRARY_PATH explicitly in the environment does not resolve the issue and the CMakeLists.txt for each affected test needs to be modified.
Motivation and Context
This fixes an issue when attempting to run the unittests on Apple Silicon.
Error produced for one of the tests
Impact
No external impact.
Test Plan
N/A
Contributor checklist
Release Notes