[native] Use Velox::TypeParser instead of Antlr and remove Antlr#21357
[native] Use Velox::TypeParser instead of Antlr and remove Antlr#21357majetideepak merged 1 commit intoprestodb:masterfrom
Conversation
6fc52fe to
d6ae606
Compare
8d08a94 to
992c22e
Compare
992c22e to
14b1e67
Compare
|
@kevinwilfong can you share your feedback? Thanks. |
14b1e67 to
7c7be0a
Compare
7c7be0a to
4b7edfc
Compare
|
Thanks! This looks great, it makes it more consistent with the rest of the code, and gets rid of that annoying issue with ANTLR messing with preprocessor identifiers. Also, thank you for preserving the caching logic. cc: @xiaoxmeng @mbasmanova for a review, the change looks good to me, but I'm not a code owner yet |
|
@majetideepak the broken linux-*-e2e-tests look like they're due to a parsing error |
4b7edfc to
bc2c724
Compare
@kevinwilfong The parsing error was fixed in Velox. CI now passed with rebasing. |
|
@mbasmanova, @xiaoxmeng can you also review? Thanks. |
mbasmanova
left a comment
There was a problem hiding this comment.
@majetideepak Please, add [native] prefix to commit and PR.
mbasmanova
left a comment
There was a problem hiding this comment.
Very nice. Thank you, Deepak.
bc2c724 to
0139339
Compare
Description
Use Velox::TypeParser instead of Antlr.
Remove Antlr dependency.
Motivation and Context
Resolves #21334
Contributor checklist