Skip to content

Add test case for deletion in Iceberg table with partition evolution #21298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hantangwangd merged 1 commit into from
Nov 4, 2023
Merged

Add test case for deletion in Iceberg table with partition evolution #21298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,37 @@ public void testDelete()
assertQuerySucceeds("DROP TABLE test_partitioned_drop");
}

@Test
public void testDeleteWithPartitionSpecEvolution()
{
// Create a partitioned table and insert some value
assertQuerySucceeds("create table test_delete(a int, b varchar) with (partitioning = ARRAY['a'])");
assertQuerySucceeds("insert into test_delete values(1, '1001'), (1, '1002'), (2, '1003')");
assertEquals(getQueryRunner().execute("SELECT count(*) FROM test_delete").getOnlyValue(), 3L);

// Rename partition column would not affect metadata deletion filtering by it's value
assertQuerySucceeds("alter table test_delete rename column a to c");
assertQuerySucceeds("insert into test_delete(c, b) values(2, '1004')");
assertUpdate("DELETE FROM test_delete WHERE c = 2", 2L);
assertEquals(getQueryRunner().execute("SELECT count(*) FROM test_delete").getOnlyValue(), 2L);

// Add a new partition column, and insert some value
assertQuerySucceeds("alter table test_delete add column d bigint with(partitioning = 'identity')");
assertQuerySucceeds("insert into test_delete values(1, '1001', 10001), (2, '1003', 10001), (3, '1004', 10003)");
assertEquals(getQueryRunner().execute("SELECT count(*) FROM test_delete").getOnlyValue(), 5L);

// Deletion fails, because column 'd' do not exists in older partition specs
String errorMessage = "This connector only supports delete where one or more partitions are deleted entirely";
assertQueryFails("delete from test_delete where d = 1001", errorMessage);
assertQueryFails("delete from test_delete where d = 1001 and c = 2", errorMessage);

// Deletion succeeds, because column 'c' exists in all partition specs
assertUpdate("DELETE FROM test_delete WHERE c = 1", 3);
assertEquals(getQueryRunner().execute("SELECT count(*) FROM test_delete").getOnlyValue(), 2L);

assertQuerySucceeds("DROP TABLE test_delete");
}

@Test
public void testRenamePartitionColumn()
{
Expand Down