Skip to content

Add test case for deletion in Iceberg table with partition evolution#21298

Merged
hantangwangd merged 1 commit intoprestodb:masterfrom
hantangwangd:master
Nov 4, 2023
Merged

Add test case for deletion in Iceberg table with partition evolution#21298
hantangwangd merged 1 commit intoprestodb:masterfrom
hantangwangd:master

Conversation

@hantangwangd
Copy link
Copy Markdown
Member

@hantangwangd hantangwangd commented Nov 2, 2023

Description

Add test case for metadata deletion in Iceberg table which have experienced partition evolution.

Motivation and Context

Make sure metadata deletion would work well in case of various partition spec evolution.

Test Plan

  • Confirm renaming partition column do not affect metadata deletion filtering by it's value
  • Confirm deletion will fail when some filter columns do not exist in all partition specs
  • Confirm deletion will succeed when all filter columns exist in all partition specs

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@hantangwangd hantangwangd requested a review from a team as a code owner November 2, 2023 09:05
Copy link
Copy Markdown
Contributor

@ZacBlanco ZacBlanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Was there a specific case you are adding this now or did you miss it in a previous commit? Does this make sense to just combine into your other PR in #21294 ?

@hantangwangd
Copy link
Copy Markdown
Member Author

LGTM! Was there a specific case you are adding this now or did you miss it in a previous commit? Does this make sense to just combine into your other PR in #21294 ?

Actually, this PR is to supplement test cases for PR #21048 after we supported partition evolution by renaming/adding columns. So I think it's more suitable to be in a separate PR from #21294 which intend to disallow explicitly dropping partition column.

@hantangwangd hantangwangd merged commit e9b4ed4 into prestodb:master Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants