Skip to content

Update Low memory Monitor feature config to experimental #21053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swapsmagic merged 1 commit into from
Oct 11, 2023
Merged

Update Low memory Monitor feature config to experimental #21053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions presto-main/src/main/java/com/facebook/presto/execution/TaskManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,8 +588,8 @@ public double getMemoryBasedSlowDownThreshold()
return memoryBasedSlowDownThreshold;
}

@Config("task.memory-based-slowdown-threshold")
@ConfigDescription("Pause processing new leaf split if heap memory usage crosses the threshold")
@Config("experimental.task.memory-based-slowdown-threshold")
@ConfigDescription("Pause processing new leaf split if heap memory usage crosses the threshold. This feature is experimental and use it with caution as could lead to deadlock.")
public TaskManagerConfig setMemoryBasedSlowDownThreshold(double memoryBasedSlowDownThreshold)
{
this.memoryBasedSlowDownThreshold = memoryBasedSlowDownThreshold;
Expand Down
2 changes: 1 addition & 1 deletion presto-main/src/test/java/com/facebook/presto/execution/TestTaskManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public void testExplicitPropertyMappings()
.put("task.legacy-lifespan-completion-condition", "true")
.put("task.task-priority-tracking", "QUERY_FAIR")
.put("task.interrupt-runaway-splits-timeout", "599s")
.put("task.memory-based-slowdown-threshold", "0.9")
.put("experimental.task.memory-based-slowdown-threshold", "0.9")
.build();

TaskManagerConfig expected = new TaskManagerConfig()
Expand Down