Skip to content

Update Low memory Monitor feature config to experimental#21053

Merged
swapsmagic merged 1 commit intoprestodb:masterfrom
swapsmagic:fixing_documentation_and_naming
Oct 11, 2023
Merged

Update Low memory Monitor feature config to experimental#21053
swapsmagic merged 1 commit intoprestodb:masterfrom
swapsmagic:fixing_documentation_and_naming

Conversation

@swapsmagic
Copy link
Contributor

@swapsmagic swapsmagic commented Oct 6, 2023

Description

Enabling low memory monitor has its risk of potential deadlock, so making it experimental. Also adding details in the config description.

Motivation and Context

Given the feature can potentially cause deadlock, updating it as experimental and adding details in the description.

Impact

Updating documentation and marking feature as experimental.

Test Plan

unit test

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@swapsmagic swapsmagic requested a review from a team as a code owner October 6, 2023 06:18
@swapsmagic swapsmagic requested a review from presto-oss October 6, 2023 06:18
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swapsmagic!

@ajaygeorge
Copy link
Contributor

nit: Change the commit message to be in imperative mood.
Updating -> Update

@swapsmagic swapsmagic force-pushed the fixing_documentation_and_naming branch 2 times, most recently from 28df312 to 15b82a4 Compare October 6, 2023 18:42
@swapsmagic swapsmagic changed the title Updating Low memory Monitor feature config to experimental Update Low memory Monitor feature config to experimental Oct 6, 2023
@swapsmagic swapsmagic force-pushed the fixing_documentation_and_naming branch from 15b82a4 to 0a7f766 Compare October 6, 2023 19:52
Copy link
Contributor

@ajaygeorge ajaygeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swapsmagic swapsmagic force-pushed the fixing_documentation_and_naming branch 2 times, most recently from 7492c62 to b17a761 Compare October 9, 2023 17:59
@tdcmeehan tdcmeehan self-assigned this Oct 9, 2023
@swapsmagic swapsmagic force-pushed the fixing_documentation_and_naming branch 2 times, most recently from bb72530 to 6f6f705 Compare October 10, 2023 15:08
Enabling low memory monitor has its risk of potential deadlock, so making it experimental.
Also adding details in the config description.
@swapsmagic swapsmagic force-pushed the fixing_documentation_and_naming branch from 6f6f705 to 8bde4a3 Compare October 10, 2023 23:04
@swapsmagic swapsmagic merged commit 01c962e into prestodb:master Oct 11, 2023
@swapsmagic swapsmagic deleted the fixing_documentation_and_naming branch October 11, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants