Skip to content

[native pos] revert TaskMetrics update to end of task #20397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shrinidhijoshi merged 1 commit into from
Jul 29, 2023
Merged

[native pos] revert TaskMetrics update to end of task #20397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...com/facebook/presto/spark/execution/nativeprocess/HttpNativeExecutionTaskInfoFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import com.facebook.presto.server.RequestErrorTracker;
import com.facebook.presto.server.smile.BaseResponse;
import com.facebook.presto.spark.execution.http.PrestoSparkHttpTaskClient;
import com.facebook.presto.spark.util.PrestoSparkStatsCollectionUtils;
import com.facebook.presto.spi.PrestoException;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.util.concurrent.ListenableFuture;
Expand Down Expand Up @@ -119,11 +118,6 @@ private void onSuccess(BaseResponse<TaskInfo> result)

errorTracker.requestSucceeded();

// Update Spark Accumulators for spark internal metrics
// Note: Updating here also serves as a heartbeat to spark scheduler
// that the task is making progress
PrestoSparkStatsCollectionUtils.collectMetrics(taskInfo.get());

if (result.getValue().getTaskStatus().getState().isDone()) {
synchronized (taskFinished) {
taskFinished.notifyAll();
Expand Down
4 changes: 4 additions & 0 deletions ...n/java/com/facebook/presto/spark/execution/task/PrestoSparkNativeTaskExecutorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
import com.facebook.presto.spark.execution.nativeprocess.NativeExecutionProcessFactory;
import com.facebook.presto.spark.execution.shuffle.PrestoSparkShuffleInfoTranslator;
import com.facebook.presto.spark.execution.shuffle.PrestoSparkShuffleWriteInfo;
import com.facebook.presto.spark.util.PrestoSparkStatsCollectionUtils;
import com.facebook.presto.spark.util.PrestoSparkUtils;
import com.facebook.presto.spi.PrestoException;
import com.facebook.presto.spi.page.PagesSerde;
Expand Down Expand Up @@ -311,6 +312,9 @@ private static void completeTask(boolean success, CollectionAccumulator<Serializ
}
SerializedTaskInfo serializedTaskInfo = new SerializedTaskInfo(serializeZstdCompressed(taskInfoCodec, taskInfoOptional.get()));
taskInfoCollector.add(serializedTaskInfo);

// Update Spark Accumulators for spark internal metrics
PrestoSparkStatsCollectionUtils.collectMetrics(taskInfoOptional.get());
}

private static void processTaskInfoForErrorsOrCompletion(TaskInfo taskInfo)
Expand Down