[native pos] revert TaskMetrics update to end of task#20397
Merged
shrinidhijoshi merged 1 commit intoprestodb:masterfrom Jul 29, 2023
Merged
[native pos] revert TaskMetrics update to end of task#20397shrinidhijoshi merged 1 commit intoprestodb:masterfrom
shrinidhijoshi merged 1 commit intoprestodb:masterfrom
Conversation
shrinidhijoshi
force-pushed
the
revertTaskMetricsUpdate
branch
3 times, most recently
from
64c6e8c to
4c31659
Compare
mbasmanova
approved these changes
Jul 27, 2023
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
Would you update commit message to explain a bit more why you are reverting this change?
shrinidhijoshi
force-pushed
the
revertTaskMetricsUpdate
branch
2 times, most recently
from
487ef69 to
8a2e9e9
Compare
Reverting (prestodb#20295) until we figure out why metrics aren't updating. Current investigation shows that TaskContext object, which is needed during metrics update, is not available in the HttpNativeExecutionTaskInfoFetcher thread. So reverting to doing the task metrics update in the PrestoNativeTaskExecutorFactory until we investigate and come with a fix.
shrinidhijoshi
force-pushed
the
revertTaskMetricsUpdate
branch
from
8a2e9e9 to
73adbec
Compare
Collaborator
Author
|
Thanks @mbasmanova . Added more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting (#20295) until
we figure out why metrics aren't updating.
Current investigation shows that TaskContext object, which is
needed during metrics update, is not available in the
HttpNativeExecutionTaskInfoFetcher thread. So reverting to doing
the task metrics update in the PrestoNativeTaskExecutorFactory
until we investigate and come with a fix.