Remove IMemoryManager interface#20345
Merged
tanjialiang merged 1 commit intoprestodb:masterfrom Jul 20, 2023
Merged
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D47560079 |
xiaoxmeng
approved these changes
Jul 19, 2023
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@tanjialiang LGTM. Thanks!
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Jul 20, 2023
Summary: X-link: prestodb/presto#20345 Removing the interface as there is no use case needed for this interface Pull Request resolved: #5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: b650c3d18e62887f01731471195533c54a6e582b
tanjialiang
force-pushed
the
export-D47560079
branch
2 times, most recently
from
5eace54 to
f6868a3
Compare
Summary: Removing the interface as there is no use case needed for this interface X-link: facebookincubator/velox#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: f6bd797b780dcadbc7768bde9dba2317518a259a
tanjialiang
force-pushed
the
export-D47560079
branch
from
f6868a3 to
f701826
Compare
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removing the interface as there is no use case needed for this interface
X-link: facebookincubator/velox#5703
Reviewed By: xiaoxmeng
Differential Revision: D47560079
Pulled By: tanjialiang