Remove IMemoryManager interface#5703
Remove IMemoryManager interface#5703tanjialiang wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@tanjialiang thanks for the refactor!
|
|
||
| /// Tries to get the singleton memory manager. If not previously initialized, | ||
| /// the process singleton manager will be initialized with the given capacity. | ||
| FOLLY_EXPORT static MemoryManager& getInstance( |
There was a problem hiding this comment.
Move this to cc? thanks!
velox/common/memory/Memory.h
Outdated
| const std::string& name = "", | ||
| int64_t capacity = kMaxMemory, | ||
| std::unique_ptr<MemoryReclaimer> reclaimer = nullptr) = 0; | ||
| int64_t maxBytes = kMaxMemory, |
There was a problem hiding this comment.
Let' call this capacity?
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Removing the interface as there is no use case needed for this interface Pull Request resolved: facebookincubator#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: effe66d11d0a142f86952a5476b5cb46b122e6ff
|
This pull request was exported from Phabricator. Differential Revision: D47560079 |
Summary: Removing the interface as there is no use case needed for this interface Pull Request resolved: facebookincubator#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: d4a9e678b6cb4b37640a0fd86cf535520fa6a8ec
|
This pull request was exported from Phabricator. Differential Revision: D47560079 |
Summary: Removing the interface as there is no use case needed for this interface Pull Request resolved: facebookincubator#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: f07acbb51caf81b9f950e27a1bbcba72e9f17b52
|
This pull request was exported from Phabricator. Differential Revision: D47560079 |
|
@tanjialiang merged this pull request in fe3d937. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Summary: Removing the interface as there is no use case needed for this interface X-link: facebookincubator/velox#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: f6bd797b780dcadbc7768bde9dba2317518a259a
Summary: Removing the interface as there is no use case needed for this interface X-link: facebookincubator/velox#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: f6bd797b780dcadbc7768bde9dba2317518a259a
Summary: Removing the interface as there is no use case needed for this interface X-link: facebookincubator/velox#5703 Reviewed By: xiaoxmeng Differential Revision: D47560079 Pulled By: tanjialiang fbshipit-source-id: f6bd797b780dcadbc7768bde9dba2317518a259a
3 participants
Removing the interface as there is no use case needed for this interface