Skip to content

Improve the memory accounting for different BatchStreamReaders#19156

Draft
MnO2 wants to merge 1 commit intoprestodb:masterfrom
MnO2:account-batch-stream-readers
Draft

Improve the memory accounting for different BatchStreamReaders#19156
MnO2 wants to merge 1 commit intoprestodb:masterfrom
MnO2:account-batch-stream-readers

Conversation

@MnO2
Copy link
Copy Markdown
Contributor

@MnO2 MnO2 commented Mar 8, 2023

Test plan - (Please fill in how you tested your changes)

  • Inspired by this Trino's memory accounting fix: Fix worker OOM trinodb/trino#9949
  • It seems that we have a few places in our Orc reader where the setBytes are not passed with the correct retained bytes. They are only passed with the individual allocated array but not the total retained size.
  • This diff corrects the accounting on them.
== NO RELEASE NOTE ==

@MnO2 MnO2 force-pushed the account-batch-stream-readers branch 2 times, most recently from b659166 to 7e8e58d Compare March 13, 2023 16:22
@MnO2 MnO2 force-pushed the account-batch-stream-readers branch from 7e8e58d to 03cdc8c Compare March 14, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant